jinchengchenghh commented on code in PR #12964:
URL: https://github.com/apache/gluten/pull/12964#discussion_r4549430599


##########
gluten-iceberg/src/main/scala/org/apache/iceberg/spark/source/GlutenIcebergSourceUtil.scala:
##########
@@ -46,12 +46,23 @@ object GlutenIcebergSourceUtil {
   private val InputFileBlockLengthCol = "input_file_block_length"
 
   def isSupportedScan(sparkScan: Scan): Boolean = sparkScan match {
-    case _: SparkBatchQueryScan | _: SparkStagedScan => true
+    case _: SparkBatchQueryScan | _: SparkStagedScan | _: SparkCopyOnWriteScan 
=> true
     case _ => false
   }
 
   def isSparkStagedScan(sparkScan: Scan): Boolean = 
sparkScan.isInstanceOf[SparkStagedScan]
 
+  def hasOrcFiles(sparkScan: Scan): Boolean =

Review Comment:
   Please rename the function, it also checks the scan task



##########
ep/build-velox/src/iceberg-row-index.patch:
##########
@@ -0,0 +1,15 @@
+diff --git a/velox/connectors/hive/iceberg/IcebergSplitReader.cpp 
b/velox/connectors/hive/iceberg/IcebergSplitReader.cpp
+--- a/velox/connectors/hive/iceberg/IcebergSplitReader.cpp
++++ b/velox/connectors/hive/iceberg/IcebergSplitReader.cpp
+@@ -1307,5 +1307,11 @@ std::vector<TypePtr> IcebergSplitReader::adaptColumns(
+   // Iceberg table stores all column's data in data file.
+   for (const auto& childSpec : childrenSpecs) {
++    // Generated row indexes are not stored in the file. Preserve their scan

Review Comment:
   Why you use the patch instead of merge to IBM velox branch?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to