Copilot commented on code in PR #13630:
URL: https://github.com/apache/gluten/pull/13630#discussion_r4550836230
##########
gluten-celeborn/src/main/java/org/apache/spark/shuffle/gluten/celeborn/CelebornUtils.java:
##########
@@ -53,7 +53,7 @@ public class CelebornUtils {
public static final String FAILED_SHUFFLE_CLEANER_NAME =
"org.apache.celeborn.spark.FailedShuffleCleaner";
public static final String GET_REDUCER_FILE_GROUP_RESPONSE_NAME =
-
"org.apache.celeborn.common.protocol.message.ControlMessages.GetReducerFileGroupResponse";
+
"org.apache.celeborn.common.protocol.message.ControlMessages$GetReducerFileGroupResponse";
Review Comment:
Hardcoding binary class names is brittle and easy to regress (as shown by
the `.` vs `$` issue). If this class is on the compile classpath, prefer
deriving this value from
`ControlMessages.GetReducerFileGroupResponse.class.getName()` (or equivalent)
to avoid typos and future refactors silently breaking reflective loading.
##########
gluten-celeborn/src/main/java/org/apache/spark/shuffle/gluten/celeborn/CelebornUtils.java:
##########
@@ -53,7 +53,7 @@ public class CelebornUtils {
public static final String FAILED_SHUFFLE_CLEANER_NAME =
"org.apache.celeborn.spark.FailedShuffleCleaner";
public static final String GET_REDUCER_FILE_GROUP_RESPONSE_NAME =
-
"org.apache.celeborn.common.protocol.message.ControlMessages.GetReducerFileGroupResponse";
+
"org.apache.celeborn.common.protocol.message.ControlMessages$GetReducerFileGroupResponse";
Review Comment:
The PR title/description discusses skipping hidden directories during
recursive Hive scans, but the only change in this diff is in Celeborn shuffle
utilities (a class-name string). Please align the PR metadata with the actual
change, or include the Hive scan changes described in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]