Copilot commented on code in PR #13632:
URL: https://github.com/apache/gluten/pull/13632#discussion_r4556813489
##########
dev/release/build-release.sh:
##########
@@ -38,14 +37,11 @@ else
exit 1
fi
-# Build Gluten for Spark 3.4 and 3.5 with Java 17. The version of Iceberg
being used requires Java 11 or higher.
-# All feature modules are enabled.
-for spark_version in 3.4 3.5
+for spark_version in 3.4 3.5 4.0 4.1
do
${GLUTEN_HOME}/build/mvn clean install -Pjava-17 -Pbackends-velox
-Pspark-${spark_version} -Pceleborn,uniffle \
Review Comment:
This collapses Spark 4.0/4.1 builds into the same Maven invocation as Spark
3.x, but it drops the previously explicit `-Pscala-2.13` for Spark 4.x. If the
`spark-4.x` profiles don’t force Scala 2.13 internally, these builds may target
the wrong Scala version or fail. Consider adding conditional logic to enable
`-Pscala-2.13` for Spark >= 4.0 (or ensure the `spark-4.x` profiles enforce
Scala 2.13).
##########
dev/release/build-release.sh:
##########
@@ -25,9 +25,8 @@ cd ${GLUTEN_HOME}
./dev/builddeps-veloxbe.sh --enable_vcpkg=ON --build_arrow=OFF
--build_tests=OFF --build_benchmarks=OFF \
--build_examples=OFF --enable_s3=ON --enable_gcs=ON
--enable_hdfs=ON --enable_abfs=ON
-sudo curl -Lo /etc/yum.repos.d/corretto.repo
https://yum.corretto.aws/corretto.repo
-sudo yum install -y java-17-amazon-corretto-devel
-export JAVA_HOME=/usr/lib/jvm/java-17-amazon-corretto
+sudo yum install -y java-17-openjdk-devel
Review Comment:
The workflow now runs inside a container (`container:
apache/gluten:vcpkg-almalinux-8-gcc13`). Containers often run as `root` and may
not have `sudo` installed; invoking `sudo` can fail even though the command
itself is permitted. Consider removing `sudo` from this script (or guarding it,
e.g., use `yum` directly when already root) to keep the workflow reliable in
containerized runs.
##########
dev/release/build-release.sh:
##########
@@ -25,9 +25,8 @@ cd ${GLUTEN_HOME}
./dev/builddeps-veloxbe.sh --enable_vcpkg=ON --build_arrow=OFF
--build_tests=OFF --build_benchmarks=OFF \
--build_examples=OFF --enable_s3=ON --enable_gcs=ON
--enable_hdfs=ON --enable_abfs=ON
-sudo curl -Lo /etc/yum.repos.d/corretto.repo
https://yum.corretto.aws/corretto.repo
-sudo yum install -y java-17-amazon-corretto-devel
-export JAVA_HOME=/usr/lib/jvm/java-17-amazon-corretto
+sudo yum install -y java-17-openjdk-devel
+export JAVA_HOME=/usr/lib/jvm/java-17-openjdk
Review Comment:
Hard-coding `JAVA_HOME=/usr/lib/jvm/java-17-openjdk` is brittle across
distros/packaging (the actual OpenJDK path can vary). Prefer deriving
`JAVA_HOME` from the installed `java` binary (e.g., resolving `which java` and
walking up the directory tree) to make the release script portable and reduce
environment-specific failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]