pedrumj2 commented on PR #13639:
URL: https://github.com/apache/gluten/pull/13639#issuecomment-6868348310

   @rui-mo @philo-he if you get the chance would appreciate if you can take a 
look here. 
   
   This is more of a code clean up PR. I notice we have test exclusions and 
test overrides since the exceptions velox engine throws is different than that 
of spark:
   ```
   .exclude("length check for input string values: nested in map key")
   ```
   
   Wondering if this would be a direction the repository would want to take and 
ensure engine exceptions are translated back to spark exceptions. This would 
avoid the test overrides. 
   
   I saw the necessary hooks were enabled in 
https://github.com/apache/gluten/pull/11684/changes wondering if we'd want to 
expand on that
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to