rdtr commented on code in PR #13518: URL: https://github.com/apache/gluten/pull/13518#discussion_r4572614606
########## gluten-core/src/main/scala/org/apache/spark/shuffle/GlutenShuffleManager.scala: ########## @@ -29,6 +29,10 @@ import org.apache.spark.annotation.Experimental * Experimental: This is not expected to be used in production yet. Use backend shuffle manager * (e.g., ColumnarShuffleManager or other RSS shuffle manager provided in Gluten's code * base)instead. + * + * TODO: Spark 4.3 requires `spark.shuffle.manager` to be a `BlockingShuffleManager` (a Review Comment: `CelebornShuffleManager` implements `ShuffleManager` directly (`CelebornShuffleManager.java:42`), so Spark 4.3 rejects it at startup the same way (`SparkEnv.scala:397-406`). Could you add it to the TODO or to #13517? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
