Mariamalmesfer commented on PR #13389: URL: https://github.com/apache/gluten/pull/13389#issuecomment-6879226270
Thanks @rdtr and @philo-he! That works for me. I’ll remove the overlay function, its registration, and `genGetTimestampTransformer`. I’ll keep `GetTimestampAnsiValidateSuite` and update the `try_to_timestamp` tests to expect a fallback to Spark when ANSI is on. I’ll run the updated tests once Gluten’s Velox pin includes facebookincubator/velox#19333. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
