zhouyuan commented on code in PR #13456:
URL: https://github.com/apache/gluten/pull/13456#discussion_r4641107109


##########
.github/workflows/iceberg_spark_ut.yml:
##########
@@ -182,31 +180,65 @@ jobs:
           if-no-files-found: error
           overwrite: true
       - name: Download the saved baseline or lookup diagnostic
-        if: always()
+        if: always() && needs.prepare.result == 'success'
         uses: actions/download-artifact@v8
         with:
           name: iceberg-baseline-lookup
           path: iceberg-base
       - name: Download freshly tested base shards
+        id: download-base
         if: always() && needs.prepare.outputs.run_base == 'true'
         uses: actions/download-artifact@v8
         with:
           pattern: iceberg-upstream-spark3.5-base-shard*
           path: iceberg-base
       - name: Merge and validate every base shard
         id: base
-        if: always() && needs.prepare.outputs.run_base == 'true'
+        if: >-
+          always() && needs.prepare.outputs.run_base == 'true' &&
+          needs.iceberg-base-test.result == 'success' &&
+          steps.download-base.outcome == 'success' &&
+          hashFiles('iceberg-base/**/execution-coverage.json') != ''
         env:
           BASELINE_KEY: ${{ needs.prepare.outputs.baseline_key }}
           BASE_SHA: ${{ needs.prepare.outputs.base_sha }}
-          BASE_RESULT: ${{ needs.iceberg-base-test.result }}
         run: |
-          test "$BASE_RESULT" = success
           python3 .github/workflows/util/iceberg-upstream/merge.py 
iceberg-base --shards "$ICEBERG_SHARD_COUNT"
           python3 .github/workflows/util/iceberg-upstream/baseline.py record \
-            --directory iceberg-base --key "$BASELINE_KEY" --revision 
"$BASE_SHA"
-      - name: Reject regressions or validate initial baseline evidence
+            --directory iceberg-base --key "$BASELINE_KEY" --revision 
"$BASE_SHA" --kind base \
+            --native-image "$NATIVE_IMAGE" --test-image "$TEST_IMAGE"
+      # Cache the validated base independently of head build/tests and 
comparison.
+      - name: Save the tested base for reuse
+        if: always() && steps.base.outcome == 'success'
+        uses: actions/upload-artifact@v7
+        with:
+          name: ${{ needs.prepare.outputs.baseline_key }}
+          path: |
+            iceberg-base/baseline-identity.json
+            iceberg-base/execution-coverage.json
+          if-no-files-found: error
+          overwrite: true
+      - name: Download available build diagnostics
         if: always()
+        uses: actions/download-artifact@v8

Review Comment:
   The artifacts are available on PR branch only. Would there be a issue if the 
artifacts are missing?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to