jdaugherty commented on code in PR #14710:
URL: https://github.com/apache/grails-core/pull/14710#discussion_r2072288113
##########
grails-bootstrap/build.gradle:
##########
@@ -38,12 +38,10 @@ dependencies {
exclude group: 'org.codehaus.groovy'
}
- // we have to continue to compile with groovy 3 only because of
grails-shell
- // the grails-shell will run under gradle and thus this must remain
compatible
- compileOnly "org.codehaus.groovy:groovy:$GroovySystem.version"
- compileOnly "org.codehaus.groovy:groovy-templates:$GroovySystem.version"
- compileOnly "org.codehaus.groovy:groovy-xml:$GroovySystem.version"
- compileOnly "org.codehaus.groovy:groovy-ant:$GroovySystem.version"
+ compileOnly 'org.apache.groovy:groovy'
Review Comment:
I spoke to @jamesfredley about this change. Since bootstrap is included by
both gorm, and core, we should be compiling with 4. We'll know if it breaks
b/c shell still uses 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
