jamesfredley commented on code in PR #425:
URL:
https://github.com/apache/grails-static-website/pull/425#discussion_r2766140492
##########
assets/javascripts/plugins-search.js:
##########
@@ -64,145 +113,102 @@ function resetDefault() {
hideElementsByClassName(searchResultsHeadingLabelClassName)
clearSearchResultsDiv()
for (let i = 0; i < elementsClassNames.length; i++) {
- const className = elementsClassNames[i];
- showElementsByClassName(className);
+ showElementsByClassName(elementsClassNames[i])
}
- paginate(defaultPluginList, max, pluginsContainer,
paginationContainerClass);
+ paginate(defaultPluginList, max, pluginsContainer,
paginationContainerClass)
}
function hideElementsByClassName(className) {
- const elements = document.getElementsByClassName(className);
+ const elements = document.getElementsByClassName(className)
for (let i = 0; i < elements.length; i++) {
- const element = elements[i];
- element.classList.add("hidden");
+ elements[i].classList.add('hidden')
}
}
function showElementsByClassName(className) {
- const elements = document.getElementsByClassName(className);
+ const elements = document.getElementsByClassName(className)
for (let i = 0; i < elements.length; i++) {
- const element = elements[i];
- element.classList.remove("hidden");
+ elements[i].classList.remove('hidden')
}
}
-function labelsAtPlugin(element) {
-
- const labels = [];
- for (let y = 0; y < element.length; y++) {
- labels.push(element[y].textContent)
- }
- return labels;
-}
+const labelsAtPlugin = elements =>
+ [...elements].map(el => el.textContent);
function clearSearchResultsDiv() {
- searchResultsDiv.innerHTML = ""
+ searchResultsDiv.innerHTML = ''
}
function onQueryChanged() {
- let query = queryValue()?.trim();
- const matchingPlugins = [];
- if (query === null || query === "") {
- resetDefault();
- return;
+ let query = queryValue()?.trim()
+ const matchingPlugins = []
+ if (query === null || query === '') {
+ resetDefault()
+ return
} else if (query.length < 3) {
Review Comment:
As an additional change, I think we should reduce this to 2, so that `DB`
submits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
