jamesfredley commented on code in PR #1205:
URL:
https://github.com/apache/grails-spring-security/pull/1205#discussion_r2829738414
##########
plugin-core/plugin/src/main/groovy/grails/plugin/springsecurity/SecurityAutoConfigurationExcluder.groovy:
##########
@@ -46,7 +58,16 @@ import
org.springframework.boot.autoconfigure.AutoConfigurationMetadata
* @see AutoConfigurationImportFilter
*/
@CompileStatic
-class SecurityAutoConfigurationExcluder implements
AutoConfigurationImportFilter {
+class SecurityAutoConfigurationExcluder implements
AutoConfigurationImportFilter, EnvironmentAware {
+
+ static final String ENABLED_PROPERTY =
'grails.plugin.springsecurity.excludeSpringSecurityAutoConfiguration'
+
+ private boolean enabled = true
+
+ @Override
+ void setEnvironment(Environment environment) {
+ this.enabled = environment.getProperty(ENABLED_PROPERTY, Boolean, true)
Review Comment:
This does work. Spring Boot's `AutoConfigurationImportSelector` explicitly
calls `invokeAwareMethods(filter)` on every `AutoConfigurationImportFilter`
**before** `match()` is ever called. The `invokeAwareMethods()` method
explicitly handles `EnvironmentAware`:
Test app:
https://github.com/jamesfredley/grails-spring-security-autoconfig-exclusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
