This is an automated email from the ASF dual-hosted git repository.
jdaugherty pushed a change to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/grails-core.git
from bc9aa89836 Merge pull request #15396 from
jamesfredley/fix/compile-static-service-injection
add f09f5f90c4 fix: use Page Object pattern for flaky Geb tests across all
subprojects
add 4be5f97fe8 fix: address review feedback - add leading slashes to URLs,
rename AdminPagePage/FrontendPagePage
add 138c52665e test: some more cleanup of geb specs
add 2e3bf9d477 ci: trigger CI re-run
add 8519169c4f docs: correct timeout settings in Geb README.md
add 4e643d216f chore: double the Geb timeout setting for CI to 10 seconds
add 7a40ae107d fix(geb): overriding default timeouts with settings
add aad9bf13b2 Merge branch '7.0.x' into fix/flaky-geb-tests
new 93e150c0df Merge pull request #15410 from
jamesfredley/fix/flaky-geb-tests
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
gradle/functional-test-config.gradle | 1 +
grails-geb/README.md | 2 +-
.../src/main/templates/FunctionalSpec.groovy | 19 +-
.../plugin/geb/WebDriverContainerHolder.groovy | 4 +-
.../functionaltests/BookFunctionalSpec.groovy | 47 ++--
.../groovy/functionaltests/HomeSpec.groovy | 37 ++-
.../groovy/functionaltests/LoadAfterSpec.groovy | 10 +-
.../functionaltests/MiscFunctionalSpec.groovy | 28 +-
.../layout/LayoutFunctionalSpec.groovy | 27 +-
.../layout/LayoutWithTemplateSpec.groovy | 13 +-
.../functionaltests/pages/BarListPage.groovy} | 12 +-
.../groovy/functionaltests/pages/BookPages.groovy} | 41 ++-
.../pages/ConventionLayoutPage.groovy} | 11 +-
.../functionaltests/pages/FooLayoutPage.groovy} | 12 +-
.../pages/FooLayoutSnippetPage.groovy} | 11 +-
.../functionaltests/pages/FooListPage.groovy} | 12 +-
.../groovy/functionaltests/pages/HomePage.groovy} | 16 +-
.../functionaltests/pages/LoginAuthPage.groovy} | 12 +-
.../groovy/functionaltests/pages/MiscPages.groovy} | 28 +-
.../functionaltests/pages/PartialPage.groovy} | 11 +-
.../scaffolding/BarFunctionalSpec.groovy | 14 +-
.../scaffolding/FooFunctionalSpec.groovy | 14 +-
.../groovy/app2/NotFoundHandlerSpec.groovy | 22 +-
.../groovy/app2/pages/FooPages.groovy} | 19 +-
.../groovy/app3/LoadAfterSpec.groovy | 9 +-
.../groovy/app3/pages/LoginAuthPage.groovy} | 12 +-
.../groovy/exploded/LoadAfterSpec.groovy | 9 +-
.../groovy/exploded/pages/LoginAuthPage.groovy} | 11 +-
.../functional/tests/BookControllerSpec.groovy | 24 +-
.../functional/tests/pages/BookPages.groovy} | 37 ++-
.../functional/tests/BookControllerSpec.groovy | 28 +-
.../functional/tests/pages/BookPages.groovy} | 37 ++-
.../functional/tests/AuthorControllerSpec.groovy | 28 +-
.../functional/tests/BookControllerSpec.groovy | 28 +-
.../functional/tests/pages/AuthorPages.groovy} | 38 ++-
.../functional/tests/pages/BookPages.groovy} | 37 ++-
.../groovy/context/ContextPathSpec.groovy | 23 +-
.../groovy/context/pages/EnvironmentPages.groovy} | 22 +-
.../groovy/namespaces/PageControllerSpec.groovy | 19 +-
.../namespaces/admin/ReportControllerSpec.groovy | 18 +-
.../namespaces/admin/pages/ReportPages.groovy} | 25 +-
.../groovy/namespaces/pages/AdminPage.groovy} | 12 +-
.../groovy/namespaces/pages/FrontendPage.groovy} | 12 +-
.../scaffoldingfields/CrudFunctionalSpec.groovy | 284 +++++++++------------
.../groovy/scaffoldingfields/FieldTypesSpec.groovy | 52 ++--
.../scaffoldingfields/pages/DepartmentPages.groovy | 5 +
.../scaffoldingfields/pages/EmployeePages.groovy | 10 +
.../pages/ScaffoldEditPage.groovy | 2 +-
.../pages/ScaffoldShowPage.groovy | 2 +-
49 files changed, 598 insertions(+), 609 deletions(-)
copy
grails-test-examples/{geb-gebconfig/src/integration-test/groovy/org/demo/spock/pages/HomePage.groovy
=> app1/src/integration-test/groovy/functionaltests/pages/BarListPage.groovy}
(82%)
copy
grails-test-examples/{scaffolding/src/integrationTest/groovy/com/example/pages/LogoutPage.groovy
=> app1/src/integration-test/groovy/functionaltests/pages/BookPages.groovy}
(52%)
copy
grails-test-examples/{scaffolding/src/integrationTest/groovy/com/example/pages/UserListPage.groovy
=>
app1/src/integration-test/groovy/functionaltests/pages/ConventionLayoutPage.groovy}
(81%)
copy
grails-test-examples/{geb-gebconfig/src/integration-test/groovy/org/demo/spock/pages/HomePage.groovy
=>
app1/src/integration-test/groovy/functionaltests/pages/FooLayoutPage.groovy}
(81%)
copy
grails-test-examples/{scaffolding/src/integrationTest/groovy/com/example/pages/UserListPage.groovy
=>
app1/src/integration-test/groovy/functionaltests/pages/FooLayoutSnippetPage.groovy}
(81%)
copy
grails-test-examples/{geb-gebconfig/src/integration-test/groovy/org/demo/spock/pages/HomePage.groovy
=> app1/src/integration-test/groovy/functionaltests/pages/FooListPage.groovy}
(82%)
copy
grails-test-examples/{scaffolding/src/integrationTest/groovy/com/example/pages/UserListPage.groovy
=> app1/src/integration-test/groovy/functionaltests/pages/HomePage.groovy}
(77%)
copy
grails-test-examples/{geb-gebconfig/src/integration-test/groovy/org/demo/spock/pages/HomePage.groovy
=>
app1/src/integration-test/groovy/functionaltests/pages/LoginAuthPage.groovy}
(81%)
copy
grails-test-examples/{scaffolding/src/integrationTest/groovy/com/example/pages/LogoutPage.groovy
=> app1/src/integration-test/groovy/functionaltests/pages/MiscPages.groovy}
(64%)
copy
grails-test-examples/{scaffolding/src/integrationTest/groovy/com/example/pages/UserListPage.groovy
=> app1/src/integration-test/groovy/functionaltests/pages/PartialPage.groovy}
(81%)
copy
grails-test-examples/{scaffolding/src/integrationTest/groovy/com/example/pages/CommunityUserListPage.groovy
=> app2/src/integration-test/groovy/app2/pages/FooPages.groovy} (75%)
copy
grails-test-examples/{geb-gebconfig/src/integration-test/groovy/org/demo/spock/pages/HomePage.groovy
=> app3/src/integration-test/groovy/app3/pages/LoginAuthPage.groovy} (82%)
copy
grails-test-examples/{geb-gebconfig/src/integration-test/groovy/org/demo/spock/pages/HomePage.groovy
=> exploded/src/integration-test/groovy/exploded/pages/LoginAuthPage.groovy}
(82%)
copy
grails-test-examples/{scaffolding/src/integrationTest/groovy/com/example/pages/LogoutPage.groovy
=>
hibernate5/grails-hibernate/src/integration-test/groovy/functional/tests/pages/BookPages.groovy}
(54%)
copy
grails-test-examples/{scaffolding/src/integrationTest/groovy/com/example/pages/LogoutPage.groovy
=>
mongodb/base/src/integration-test/groovy/functional/tests/pages/BookPages.groovy}
(54%)
copy
grails-test-examples/{scaffolding/src/integrationTest/groovy/com/example/pages/LogoutPage.groovy
=>
mongodb/hibernate5/src/integration-test/groovy/functional/tests/pages/AuthorPages.groovy}
(54%)
copy
grails-test-examples/{scaffolding/src/integrationTest/groovy/com/example/pages/LogoutPage.groovy
=>
mongodb/hibernate5/src/integration-test/groovy/functional/tests/pages/BookPages.groovy}
(54%)
copy
grails-test-examples/{scaffolding/src/integrationTest/groovy/com/example/pages/LogoutPage.groovy
=>
namespaces/src/integration-test/groovy/context/pages/EnvironmentPages.groovy}
(73%)
copy
grails-test-examples/{scaffolding/src/integrationTest/groovy/com/example/pages/LogoutPage.groovy
=>
namespaces/src/integration-test/groovy/namespaces/admin/pages/ReportPages.groovy}
(73%)
copy
grails-test-examples/{geb-gebconfig/src/integration-test/groovy/org/demo/spock/pages/HomePage.groovy
=> namespaces/src/integration-test/groovy/namespaces/pages/AdminPage.groovy}
(81%)
copy
grails-test-examples/{geb-gebconfig/src/integration-test/groovy/org/demo/spock/pages/HomePage.groovy
=>
namespaces/src/integration-test/groovy/namespaces/pages/FrontendPage.groovy}
(81%)
