SemyonSinchenko commented on code in PR #745:
URL: https://github.com/apache/incubator-graphar/pull/745#discussion_r2322338576
##########
maven-projects/info/src/main/java/org/apache/graphar/util/PathUtil.java:
##########
@@ -20,8 +20,22 @@
package org.apache.graphar.util;
public class PathUtil {
+
+ public static String resolvePath(String basePath, String subPath) {
Review Comment:
Would it be better to work with `java.net.URI`? It provides `resolve(URI
uri)`, `resolve(String uri)`. For local FS it will be just `file://`. Hadoop FS
provides resolving to `URI`, as well as `java.nio.Path` has `URI toUri()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
