SYaoJun commented on code in PR #904: URL: https://github.com/apache/incubator-graphar/pull/904#discussion_r2911789098
########## cpp/cmake/apache-arrow.cmake: ########## @@ -35,139 +35,162 @@ # This cmake file is referred and derived from # https://github.com/apache/arrow/blob/master/matlab/CMakeLists.txt - # Build the Arrow C++ libraries. function(build_arrow) - set(one_value_args) - set(multi_value_args) + set(one_value_args) + set(multi_value_args) + + cmake_parse_arguments(ARG + "${options}" + "${one_value_args}" + "${multi_value_args}" + ${ARGN}) + if(ARG_UNPARSED_ARGUMENTS) + message(SEND_ERROR "Error: unrecognized arguments: ${ARG_UNPARSED_ARGUMENTS}") + endif() - cmake_parse_arguments(ARG - "${options}" - "${one_value_args}" - "${multi_value_args}" - ${ARGN}) - if (ARG_UNPARSED_ARGUMENTS) - message(SEND_ERROR "Error: unrecognized arguments: ${ARG_UNPARSED_ARGUMENTS}") - endif () + # If Arrow needs to be built, the default location will be within the build tree. + set(GAR_ARROW_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/arrow_ep-prefix") - # If Arrow needs to be built, the default location will be within the build tree. - set(GAR_ARROW_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/arrow_ep-prefix") + set(GAR_ARROW_STATIC_LIBRARY_DIR "${GAR_ARROW_PREFIX}/lib") - set(GAR_ARROW_STATIC_LIBRARY_DIR "${GAR_ARROW_PREFIX}/lib") + set(GAR_ARROW_STATIC_LIB_FILENAME + "${CMAKE_STATIC_LIBRARY_PREFIX}arrow${CMAKE_STATIC_LIBRARY_SUFFIX}") + set(GAR_ARROW_STATIC_LIB + "${GAR_ARROW_STATIC_LIBRARY_DIR}/${GAR_ARROW_STATIC_LIB_FILENAME}" + CACHE INTERNAL "arrow lib") + set(GAR_PARQUET_STATIC_LIB_FILENAME + "${CMAKE_STATIC_LIBRARY_PREFIX}parquet${CMAKE_STATIC_LIBRARY_SUFFIX}") + set(GAR_PARQUET_STATIC_LIB + "${GAR_ARROW_STATIC_LIBRARY_DIR}/${GAR_PARQUET_STATIC_LIB_FILENAME}" + CACHE INTERNAL "parquet lib") + set(GAR_DATASET_STATIC_LIB_FILENAME + "${CMAKE_STATIC_LIBRARY_PREFIX}arrow_dataset${CMAKE_STATIC_LIBRARY_SUFFIX}") + set(GAR_DATASET_STATIC_LIB + "${GAR_ARROW_STATIC_LIBRARY_DIR}/${GAR_DATASET_STATIC_LIB_FILENAME}" + CACHE INTERNAL "arrow dataset lib") + set(GAR_ARROW_COMPUTE_STATIC_LIB_FILENAME + "${CMAKE_STATIC_LIBRARY_PREFIX}arrow_compute${CMAKE_STATIC_LIBRARY_SUFFIX}") + set(GAR_ARROW_COMPUTE_STATIC_LIB + "${GAR_ARROW_STATIC_LIBRARY_DIR}/${GAR_ARROW_COMPUTE_STATIC_LIB_FILENAME}" + CACHE INTERNAL "arrow compute lib") + set(GAR_ARROW_BUNDLED_DEPS_STATIC_LIB_FILENAME + "${CMAKE_STATIC_LIBRARY_PREFIX}arrow_bundled_dependencies${CMAKE_STATIC_LIBRARY_SUFFIX}" + ) + set(GAR_ARROW_BUNDLED_DEPS_STATIC_LIB + "${GAR_ARROW_STATIC_LIBRARY_DIR}/${GAR_ARROW_BUNDLED_DEPS_STATIC_LIB_FILENAME}" + CACHE INTERNAL "bundled deps lib") - set(GAR_ARROW_STATIC_LIB_FILENAME - "${CMAKE_STATIC_LIBRARY_PREFIX}arrow${CMAKE_STATIC_LIBRARY_SUFFIX}") - set(GAR_ARROW_STATIC_LIB "${GAR_ARROW_STATIC_LIBRARY_DIR}/${GAR_ARROW_STATIC_LIB_FILENAME}" CACHE INTERNAL "arrow lib") - set(GAR_PARQUET_STATIC_LIB_FILENAME - "${CMAKE_STATIC_LIBRARY_PREFIX}parquet${CMAKE_STATIC_LIBRARY_SUFFIX}") - set(GAR_PARQUET_STATIC_LIB "${GAR_ARROW_STATIC_LIBRARY_DIR}/${GAR_PARQUET_STATIC_LIB_FILENAME}" CACHE INTERNAL "parquet lib") - set(GAR_DATASET_STATIC_LIB_FILENAME - "${CMAKE_STATIC_LIBRARY_PREFIX}arrow_dataset${CMAKE_STATIC_LIBRARY_SUFFIX}") - set(GAR_DATASET_STATIC_LIB "${GAR_ARROW_STATIC_LIBRARY_DIR}/${GAR_DATASET_STATIC_LIB_FILENAME}" CACHE INTERNAL "arrow dataset lib") - set(GAR_ARROW_COMPUTE_STATIC_LIB_FILENAME - "${CMAKE_STATIC_LIBRARY_PREFIX}arrow_compute${CMAKE_STATIC_LIBRARY_SUFFIX}") - set(GAR_ARROW_COMPUTE_STATIC_LIB "${GAR_ARROW_STATIC_LIBRARY_DIR}/${GAR_ARROW_COMPUTE_STATIC_LIB_FILENAME}" CACHE INTERNAL "arrow compute lib") - set(GAR_ARROW_BUNDLED_DEPS_STATIC_LIB_FILENAME - "${CMAKE_STATIC_LIBRARY_PREFIX}arrow_bundled_dependencies${CMAKE_STATIC_LIBRARY_SUFFIX}") - set(GAR_ARROW_BUNDLED_DEPS_STATIC_LIB - "${GAR_ARROW_STATIC_LIBRARY_DIR}/${GAR_ARROW_BUNDLED_DEPS_STATIC_LIB_FILENAME}" CACHE INTERNAL "bundled deps lib") + set(GAR_ARROW_BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/arrow_ep-build") + set(GAR_ARROW_CMAKE_ARGS + "-DCMAKE_INSTALL_PREFIX=${GAR_ARROW_PREFIX}" + "-DARROW_BUILD_STATIC=ON" + "-DARROW_BUILD_SHARED=OFF" + "-DARROW_DEPENDENCY_SOURCE=BUNDLED" + "-DARROW_DEPENDENCY_USE_SHARED=OFF" + "-DCMAKE_INSTALL_LIBDIR=lib" + "-Dxsimd_SOURCE=BUNDLED" + "-DARROW_PARQUET=ON" + "-DARROW_WITH_RE2=OFF" + "-DARROW_WITH_UTF8PROC=OFF" + "-DARROW_WITH_RE2=OFF" + "-DARROW_FILESYSTEM=ON" + "-DARROW_CSV=ON" + "-DARROW_JSON=ON" + "-DARROW_PYTHON=OFF" + "-DARROW_BUILD_BENCHMAKRS=OFF" + "-DARROW_BUILD_TESTS=OFF" Review Comment: accepted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
