yuqi1129 commented on code in PR #3912:
URL: https://github.com/apache/gravitino/pull/3912#discussion_r1666196830
##########
catalogs/catalog-hadoop/src/test/java/com/datastrato/gravitino/catalog/hadoop/integration/test/HadoopCatalogIT.java:
##########
@@ -68,7 +68,7 @@ public class HadoopCatalogIT extends AbstractIT {
@BeforeAll
public static void setup() throws IOException {
- containerSuite.startHiveContainer();
+ containerSuite.startHiveContainer(false, ImmutableMap.of());
Review Comment:
I suggest you can add a extra method in container suite like
```java
startHiveContainer(boolean xxx) {
startHiveContainer(xxx, ImmutableMap.of()
}
startHiveContainer(boolean xxx, Map<> xxx) {
// core logic
}
```
In this way, we can avoid some unnecessary changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
