jerryshao commented on code in PR #4219:
URL: https://github.com/apache/gravitino/pull/4219#discussion_r1689064894
##########
server-common/src/main/java/org/apache/gravitino/server/authentication/KerberosServerUtils.java:
##########
@@ -248,22 +249,22 @@ public static String getTokenServerName(byte[] rawToken) {
throw new IllegalArgumentException("Malformed gss token");
}
// InnerContextToken ::= {
- // token-id[1]
- // AP-REQ
+ // token-id[1]
+ // AP-REQ
// }
if (token.next().getTag() != 1) {
throw new IllegalArgumentException("Not an AP-REQ token");
}
// AP-REQ ::= [APPLICATION 14] SEQUENCE {
- // ticket[3] Ticket
+ // ticket[3] Ticket
// }
DER ticket = token.next().get(0x6e, 0x30, 0xa3, 0x61, 0x30);
// Ticket ::= [APPLICATION 1] SEQUENCE {
- // realm[1] String
- // sname[2] PrincipalName
+ // realm[1] String
+ // sname[2] PrincipalName
// }
// PrincipalName ::= SEQUENCE {
- // name-string[1] SEQUENCE OF String
+ // name-string[1] SEQUENCE OF String
Review Comment:
I think the changes here and above are not necessary, it would be better not
to change them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
