xunliu commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1768665627
##########
catalogs/catalog-lakehouse-iceberg/src/test/java/org/apache/gravitino/catalog/lakehouse/iceberg/TestIcebergTable.java:
##########
@@ -76,13 +76,13 @@ public class TestIcebergTable {
NameIdentifier.of(META_LAKE_NAME, ICEBERG_CATALOG_NAME,
ICEBERG_SCHEMA_NAME);
@BeforeAll
- private static void setup() {
+ public static void setup() {
Review Comment:
I rollback this change.
##########
spark-connector/spark-common/build.gradle.kts:
##########
@@ -56,24 +56,12 @@ dependencies {
testCompileOnly(libs.lombok)
// use log from spark, spark3.3 use low version of log4j, to avoid
java.lang.NoSuchMethodError: org.apache.logging.slf4j.Log4jLoggerFactory:
method <init>()V not found
- testImplementation(project(":api")) {
- exclude("org.apache.logging.log4j")
Review Comment:
I rollback this change.
##########
integration-test-common/build.gradle.kts:
##########
@@ -53,25 +57,37 @@ dependencies {
exclude("org.elasticsearch")
exclude("org.elasticsearch.client")
exclude("org.elasticsearch.plugin")
+ exclude("com.amazonaws", "aws-java-sdk-bundle")
}
-
testImplementation(platform("org.junit:junit-bom:5.9.1"))
testImplementation("org.junit.jupiter:junit-jupiter")
+ testImplementation(libs.bundles.jetty)
Review Comment:
I rollback this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
