Re: [PR] [#5647] improvement(build): update the jar name to add gravitino prefix [gravitino]

Mon, 25 Nov 2024 02:02:44 -0800 


orenccl commented on PR #5654:
URL: https://github.com/apache/gravitino/pull/5654#issuecomment-2497491748

   After looking into it, I found that the `artifactId` set in the root project 
doesn’t apply if the child `build.gradle.kts` files have their own `artifactId` 
settings.
   
   Moreover, it also looks like they need to do some custom work to get their 
naming conventions right.
   
   For example
   ```kotlin
   val scalaVersion: String = project.properties["scalaVersion"] as? String ?: 
extra["defaultScalaVersion"].toString()
   val sparkVersion: String = libs.versions.spark33.get()
   val sparkMajorVersion: String = sparkVersion.substringBeforeLast(".")
   val baseName = 
"${rootProject.name}-spark-connector-runtime-${sparkMajorVersion}_$scalaVersion"
   ```
   
   
![image](https://github.com/user-attachments/assets/a83f4cbc-6228-4ab3-8827-a3baeef38761)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to