FANNG1 commented on code in PR #7067:
URL: https://github.com/apache/gravitino/pull/7067#discussion_r2086838691
##########
spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/hive/SparkHiveTable.java:
##########
@@ -76,4 +83,71 @@ public Map<String, String> properties() {
public Transform[] partitioning() {
return gravitinoTableInfoHelper.partitioning();
}
+
+ @Override
+ public void createPartition(InternalRow ident, Map<String, String>
properties)
+ throws PartitionAlreadyExistsException, UnsupportedOperationException {
+ hiveGravitinoOperationOperator.createPartition(ident, properties,
partitionSchema());
+ }
+
+ @Override
+ public boolean dropPartition(InternalRow ident) {
+ return hiveGravitinoOperationOperator.dropPartition(ident,
partitionSchema());
+ }
+
+ @Override
+ public void replacePartitionMetadata(InternalRow ident, Map<String, String>
properties)
+ throws NoSuchPartitionException, UnsupportedOperationException {
+ throw new UnsupportedOperationException("Replace partition is not
supported");
+ }
+
+ @Override
+ public Map<String, String> loadPartitionMetadata(InternalRow ident)
+ throws UnsupportedOperationException {
+ return hiveGravitinoOperationOperator.loadPartitionMetadata(ident,
partitionSchema());
+ }
+
+ @Override
+ public InternalRow[] listPartitionIdentifiers(String[] names, InternalRow
ident) {
+ return hiveGravitinoOperationOperator.listPartitionIdentifiers(names,
ident, partitionSchema());
+ }
+
+ @Override
+ public boolean partitionExists(InternalRow ident) {
+ String[] partitionNames = partitionSchema().names();
Review Comment:
How about using Preconditions.checkArgument to simple the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
