tengqm commented on PR #7111:
URL: https://github.com/apache/gravitino/pull/7111#issuecomment-2889540933

   > Hi @tengqm , since line break is not easy to get consensus, to make the 
ball roll, can we just only focusing on the doc structure refactoring in this 
PR? For others like long line break, deduplication, etc, we can move to 
separate PRs, what do you think?
   
   I don't think that is feasible. This is a huge effort. I did considered 
breaking this stream into several threads, but it wouldn't work. There are 
complicated dependencies between these commits. Something must happen before 
another change can be made. At the end of the day, these threads have to be 
merged again. It could be an option if we have other contributors working on 
this, i.e. we need to divide the huge work and get it done.
   
   If you look closely into these commits, you will see that only less than 2% 
of the changes are about breaking a single long sentence into more than one 
line. I'm not counting "Line breaking" at the boundary of sentences. Those line 
wrappings cause no concern to anybody or any tools.
   
   There are two options going forward, in my view:
   
   - either reject this effort as a whole, or
   - kick this in and resolve line wrapping issues where line wrapping does 
cause a problem.
   
   I'm happy with either approach.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to