jerryshao commented on code in PR #7187:
URL: https://github.com/apache/gravitino/pull/7187#discussion_r2101581023


##########
api/src/main/java/org/apache/gravitino/policy/PolicyChange.java:
##########
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.policy;
+
+import java.util.Objects;
+import org.apache.gravitino.annotation.Evolving;
+
+/**
+ * Interface for supporting policy changes. This interface will be used to 
provide policy
+ * modification operations for each policy.
+ */
+@Evolving
+public interface PolicyChange {
+
+  /**
+   * Creates a new policy change to rename the policy.
+   *
+   * @param newName The new name of the policy.
+   * @return The policy change.
+   */
+  static PolicyChange rename(String newName) {
+    return new RenamePolicy(newName);
+  }
+
+  /**
+   * Creates a new policy change to update the policy comment.
+   *
+   * @param newComment The new comment for the policy.
+   * @return The policy change.
+   */
+  static PolicyChange updateComment(String newComment) {
+    return new UpdatePolicyComment(newComment);
+  }
+
+  /**
+   * Creates a new policy change to set the enabled or disabled state of the 
policy.
+   *
+   * @param enabled The enabled state to set.
+   * @return The policy change.
+   */
+  static PolicyChange setEnabled(boolean enabled) {
+    return new SetEnabled(enabled);
+  }
+
+  /**

Review Comment:
   Can we update the inheritable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to