Abyss-lord commented on code in PR #7181: URL: https://github.com/apache/gravitino/pull/7181#discussion_r2102233906
########## core/src/main/java/org/apache/gravitino/cache/RelationEntityCache.java: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.cache; + +import java.io.IOException; +import java.util.List; +import java.util.Optional; +import org.apache.gravitino.Entity; +import org.apache.gravitino.EntityStore; +import org.apache.gravitino.HasIdentifier; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.SupportsRelationOperations; + +/** {@code RelationEntityCache} defines caching behavior for entity-to-entity relationships. */ +public interface RelationEntityCache { Review Comment: fix. ########## core/src/main/java/org/apache/gravitino/cache/EntityCache.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.cache; + +import org.apache.gravitino.Entity; + +/** + * {@code EntityCache} is a cache interface in Gravitino designed to accelerate metadata access for + * entities. It maintains a bidirectional mapping between an {@link Entity} and its {@code + * NameIdentifier}. The cache also supports cascading removal of entries, ensuring related + * sub-entities are cleared together. + */ +public interface EntityCache extends StoreEntityCache, RelationEntityCache { + + /** Clear all cached entities. */ + void clear(); + /** Review Comment: fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
