(gravitino) branch main updated: [#7282] improvement(logging): use SLF4J formatting for alter table logs (#7294)

[jmclean]

This is an automated email from the ASF dual-hosted git repository.

jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new b6758ac83b [#7282] improvement(logging): use SLF4J formatting for 
alter table logs (#7294)
b6758ac83b is described below

commit b6758ac83b5e4e7e65cdd6ecc4dd83a72ac2df1c
Author: Aaryan Kumar Sinha <138802020+aaryansin...@users.noreply.github.com>
AuthorDate: Thu May 29 10:28:25 2025 +0530

    [#7282] improvement(logging): use SLF4J formatting for alter table logs 
(#7294)
    
    ### What changes were proposed in this pull request?
    Replaced string Concatenation in SLF4J `LOG.info` statement with
    built-in formatting in the following files:
    
    1.
    
`catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java`
    2.
    
`catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/operation/MysqlTableOperations.java`
    3.
    
`catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseTableOperations.java`
    
    
    ### Why are the changes needed?
    Using built-in formatting can help in:
    
    1. It Enables **Lazy Evaluation**, ie, the string will not be
    constructed if the log is turned off.
    2. Improves **consistency** and **best practice** throughout the
    codebase.
    3. avoids concatenation overhead at runtime.
    
    This change was requested in Issue Number #7282.
    
    ### Does this PR introduce _any_ user-facing change?
    No, It does not introduce any user-facing change as it only affects
    internal logging behavior.
    
    ### How was this patch tested?
    As this is a logging improvement, no new test cases were added. The
    change is simple and syntactic.
    However, the affected classes still compile and retain the intended
    logging output.
---
 .../apache/gravitino/catalog/doris/operation/DorisTableOperations.java  | 2 +-
 .../apache/gravitino/catalog/mysql/operation/MysqlTableOperations.java  | 2 +-
 .../gravitino/catalog/oceanbase/operation/OceanBaseTableOperations.java | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java
 
b/catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java
index 425bf51d4c..f4b99e9b01 100644
--- 
a/catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java
+++ 
b/catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java
@@ -577,7 +577,7 @@ public class DorisTableOperations extends 
JdbcTableOperations {
     }
     // Return the generated SQL statement
     String result = "ALTER TABLE `" + tableName + "`\n" + String.join(",\n", 
alterSql) + ";";
-    LOG.info("Generated alter table:{} sql: {}", databaseName + "." + 
tableName, result);
+    LOG.info("Generated alter table:{}.{} sql: {}", databaseName, tableName, 
result);
     return result;
   }
 
diff --git 
a/catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/operation/MysqlTableOperations.java
 
b/catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/operation/MysqlTableOperations.java
index 36b4daebf9..7f22a7ce74 100644
--- 
a/catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/operation/MysqlTableOperations.java
+++ 
b/catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/operation/MysqlTableOperations.java
@@ -311,7 +311,7 @@ public class MysqlTableOperations extends 
JdbcTableOperations {
     }
     // Return the generated SQL statement
     String result = "ALTER TABLE `" + tableName + "`\n" + String.join(",\n", 
alterSql) + ";";
-    LOG.info("Generated alter table:{} sql: {}", databaseName + "." + 
tableName, result);
+    LOG.info("Generated alter table:{}.{} sql: {}", databaseName, tableName, 
result);
     return result;
   }
 
diff --git 
a/catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseTableOperations.java
 
b/catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseTableOperations.java
index 98f2d174f1..50a514628a 100644
--- 
a/catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseTableOperations.java
+++ 
b/catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseTableOperations.java
@@ -326,7 +326,7 @@ public class OceanBaseTableOperations extends 
JdbcTableOperations {
     }
     // Return the generated SQL statement
     String result = "ALTER TABLE `" + tableName + "`\n" + String.join(",\n", 
alterSql) + ";";
-    LOG.info("Generated alter table:{} sql: {}", databaseName + "." + 
tableName, result);
+    LOG.info("Generated alter table:{}.{} sql: {}", databaseName, tableName, 
result);
     return result;
   }