This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push: new 21a29a6ead [#7243] Improvement](authz):onRoleDeleted in JdbcAuthorizationPlugin.java returns null (#7301) 21a29a6ead is described below commit 21a29a6ead16f7f96261b6a44bb8ef233a9f83fd Author: Xiaojian Sun <sunxiaojian...@163.com> AuthorDate: Fri May 30 08:51:27 2025 +0800 [#7243] Improvement](authz):onRoleDeleted in JdbcAuthorizationPlugin.java returns null (#7301) ### What changes were proposed in this pull request? Fixed onRoleDeleted in JdbcAuthorizationPlugin.java returns null ### Why are the changes needed? Fix: #([7243](https://github.com/apache/gravitino/issues/7243)) ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A Co-authored-by: Justin Mclean <jus...@classsoftware.com> --- .../apache/gravitino/authorization/jdbc/JdbcAuthorizationPlugin.java | 2 +- .../gravitino/authorization/jdbc/TestJdbcAuthorizationPlugin.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationPlugin.java b/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationPlugin.java index bec8ee3bac..a6ca50390e 100644 --- a/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationPlugin.java +++ b/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationPlugin.java @@ -146,7 +146,7 @@ public abstract class JdbcAuthorizationPlugin implements AuthorizationPlugin, Jd for (String sql : sqls) { executeUpdateSQL(sql); } - return null; + return true; } @Override diff --git a/authorizations/authorization-common/src/test/java/org/apache/gravitino/authorization/jdbc/TestJdbcAuthorizationPlugin.java b/authorizations/authorization-common/src/test/java/org/apache/gravitino/authorization/jdbc/TestJdbcAuthorizationPlugin.java index c229b7a92f..7bec2d6276 100644 --- a/authorizations/authorization-common/src/test/java/org/apache/gravitino/authorization/jdbc/TestJdbcAuthorizationPlugin.java +++ b/authorizations/authorization-common/src/test/java/org/apache/gravitino/authorization/jdbc/TestJdbcAuthorizationPlugin.java @@ -120,7 +120,7 @@ public class TestJdbcAuthorizationPlugin { resetSQLIndex(); expectSQLs = Lists.newArrayList("DROP ROLE tmp"); - plugin.onRoleDeleted(role); + Assertions.assertTrue(plugin.onRoleDeleted(role)); } @Test