Abyss-lord commented on PR #7354:
URL: https://github.com/apache/gravitino/pull/7354#issuecomment-2969174775
Hi @jerryshao , I've completed the code updates and would appreciate your
review of the PR when you have a moment. Here's a summary of the commits:
1. Updated the locking strategy:
- In RelationalEntityStore, all operations except get and
listEntitiesByRelation are no longer wrapped in withCacheLock.
- In CaffeineEntityCache, only mutating operations (put, invalidate,
clear, etc.) are protected by locks. Methods like contains and getIfPresent are
left lock-free, since Caffeine is thread-safe for read access.
2. Introduced SupportsEntityStoreCache interface. It's designed specifically
to handle cache invalidation scenarios triggered by inserting entities like
ModelVersion that may affect related entries such as Model.
3. Removed the usage of namespaceSet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
