hdygxsj commented on code in PR #7554:
URL: https://github.com/apache/gravitino/pull/7554#discussion_r2189087434
##########
server/src/main/java/org/apache/gravitino/server/web/rest/TableOperations.java:
##########
@@ -99,10 +116,20 @@ public Response listTables(
@Produces("application/vnd.gravitino.v1+json")
@Timed(name = "create-table." + MetricNames.HTTP_PROCESS_DURATION, absolute
= true)
@ResponseMetered(name = "create-table", absolute = true)
+ @AuthorizationExpression(
+ expression =
+ " ((METALAKE::USE_CATALOG || CATALOG::USE_CATALOG ||
SCHEMA::USE_CATALOG) && "
+ + "((METALAKE::USE_SCHEMA || CATALOG::USE_SCHEMA ||
SCHEMA::USE_SCHEMA) "
+ + "&& (METALAKE::CREATE_TABLE || CATALOG::CREATE_TABLE || "
+ + "SCHEMA::CREATE_TABLE) || SCHEMA::OWNER)) || "
Review Comment:
Please use any expression like
ANY(SELECT_TABLE,METALAKE,CATALOG,SCHEMA,TABLE)
Please refer to https://github.com/apache/gravitino/pull/7577/files
##########
server/src/main/java/org/apache/gravitino/server/web/rest/TableOperations.java:
##########
@@ -167,11 +206,21 @@ public Response loadTable(
@Produces("application/vnd.gravitino.v1+json")
@Timed(name = "alter-table." + MetricNames.HTTP_PROCESS_DURATION, absolute =
true)
@ResponseMetered(name = "alter-table", absolute = true)
+ @AuthorizationExpression(
+ expression =
+ "( (METALAKE::USE_CATALOG || CATALOG::USE_CATALOG) && "
+ + "(METALAKE::USE_SCHEMA || CATALOG::USE_SCHEMA
||SCHEMA::USE_SCHEMA) &&"
+ + " (METALAKE::MODIFY_TABLE || CATALOG::MODIFY_TABLE || "
+ + "SCHEMA::MODIFY_TABLE || TABLE::MODIFY_TABLE || TABLE::OWNER))
||"
Review Comment:
Please use any expression like
ANY(SELECT_TABLE,METALAKE,CATALOG,SCHEMA,TABLE)
Please refer to https://github.com/apache/gravitino/pull/7577/files
##########
server/src/main/java/org/apache/gravitino/server/web/rest/TableOperations.java:
##########
@@ -140,11 +167,23 @@ public Response createTable(
@Produces("application/vnd.gravitino.v1+json")
@Timed(name = "load-table." + MetricNames.HTTP_PROCESS_DURATION, absolute =
true)
@ResponseMetered(name = "load-table", absolute = true)
+ @AuthorizationExpression(
+ expression =
+ "( (METALAKE::USE_CATALOG || CATALOG::USE_CATALOG) && "
+ + "(METALAKE::USE_SCHEMA || CATALOG::USE_SCHEMA
||SCHEMA::USE_SCHEMA) &&"
+ + " (METALAKE::SELECT_TABLE || CATALOG::SELECT_TABLE || "
+ + "SCHEMA::SELECT_TABLE || TABLE::SELECT_TABLE || "
Review Comment:
Please use any expression like
ANY(SELECT_TABLE,METALAKE,CATALOG,SCHEMA,TABLE)
Please refer to https://github.com/apache/gravitino/pull/7577/files
##########
server/src/main/java/org/apache/gravitino/server/web/rest/TableOperations.java:
##########
@@ -84,6 +89,18 @@ public Response listTables(
() -> {
Namespace tableNS = NamespaceUtil.ofTable(metalake, catalog,
schema);
NameIdentifier[] idents = dispatcher.listTables(tableNS);
+ idents =
+ MetadataFilterHelper.filterByExpression(
+ metalake,
+ "( (METALAKE::USE_CATALOG || CATALOG::USE_CATALOG) && "
+ + "(METALAKE::USE_SCHEMA || CATALOG::USE_SCHEMA
||SCHEMA::USE_SCHEMA) &&"
+ + " (METALAKE::SELECT_TABLE || CATALOG::SELECT_TABLE
|| "
+ + "SCHEMA::SELECT_TABLE || TABLE::SELECT_TABLE || "
Review Comment:
Please use any expression like
ANY(SELECT_TABLE,METALAKE,CATALOG,SCHEMA,TABLE)
Please refer to https://github.com/apache/gravitino/pull/7577/files
##########
server/src/main/java/org/apache/gravitino/server/web/rest/TableOperations.java:
##########
@@ -200,11 +249,19 @@ public Response alterTable(
@Produces("application/vnd.gravitino.v1+json")
@Timed(name = "drop-table." + MetricNames.HTTP_PROCESS_DURATION, absolute =
true)
@ResponseMetered(name = "drop-table", absolute = true)
+ @AuthorizationExpression(
+ expression =
+ "METALAKE::OWNER || CATALOG::OWNER || SCHEMA::OWNER || "
Review Comment:
Please use any expression like
ANY(SELECT_TABLE,METALAKE,CATALOG,SCHEMA,TABLE)
Please refer to https://github.com/apache/gravitino/pull/7577/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
