jerqi commented on code in PR #7736:
URL: https://github.com/apache/gravitino/pull/7736#discussion_r2224741518
##########
server/src/main/java/org/apache/gravitino/server/web/rest/PermissionOperations.java:
##########
@@ -174,12 +187,18 @@ public Response revokeRolesFromGroup(
@Timed(name = "grant-privilege-to-role." +
MetricNames.HTTP_PROCESS_DURATION, absolute = true)
@ResponseMetered(name = "grant-privilege-to-role", absolute = true)
public Response grantPrivilegeToRole(
- @PathParam("metalake") String metalake,
+ @PathParam("metalake") @AuthorizationMetadata(type =
Entity.EntityType.METALAKE)
+ String metalake,
@PathParam("role") String role,
@PathParam("type") String type,
@PathParam("fullName") String fullName,
PrivilegeGrantRequest privilegeGrantRequest) {
try {
+ Preconditions.checkArgument(
Review Comment:
Could we use annotation here, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
