yuqi1129 commented on code in PR #7738:
URL: https://github.com/apache/gravitino/pull/7738#discussion_r2227096338
##########
catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/config/JdbcConfig.java:
##########
@@ -65,7 +66,7 @@ public class JdbcConfig extends Config {
.doc("The password of the Jdbc connection")
.version(ConfigConstants.VERSION_0_3_0)
.stringConf()
- .checkValue(StringUtils::isNotBlank,
ConfigConstants.NOT_BLANK_ERROR_MSG)
+ .checkValue(Objects::nonNull, ConfigConstants.NOT_BLANK_ERROR_MSG)
Review Comment:
> When I set the password to empty string in StarRocksContainer. This
Config check is fail due to it's blank.
Why do you set the password to an empty string? I believe an empty string is
not common used in production environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
