yuqi1129 commented on code in PR #7792: URL: https://github.com/apache/gravitino/pull/7792#discussion_r2242107580
########## integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/StarRocksContainer.java: ########## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.integration.test.container; + +import static java.lang.String.format; +import static org.testcontainers.shaded.org.awaitility.Awaitility.await; + +import com.google.common.collect.ImmutableSet; +import java.io.File; +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.ResultSet; +import java.sql.Statement; +import java.time.Duration; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.concurrent.TimeUnit; +import org.rnorth.ducttape.Preconditions; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.testcontainers.containers.Network; + +public class StarRocksContainer extends BaseContainer { + public static final Logger LOG = LoggerFactory.getLogger(StarRocksContainer.class); + + public static final String DEFAULT_IMAGE = "starrocks/allin1-ubuntu:3.3-latest"; + public static final String HOST_NAME = "gravitino-ci-starrocks"; + public static final String USER_NAME = "root"; + public static final String PASSWORD = ""; Review Comment: Why not use a meaningful password instead of an empty one? is that any other consideration? ########## integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/StarRocksContainer.java: ########## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.integration.test.container; + +import static java.lang.String.format; +import static org.testcontainers.shaded.org.awaitility.Awaitility.await; + +import com.google.common.collect.ImmutableSet; +import java.io.File; +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.ResultSet; +import java.sql.Statement; +import java.time.Duration; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.concurrent.TimeUnit; +import org.rnorth.ducttape.Preconditions; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.testcontainers.containers.Network; + +public class StarRocksContainer extends BaseContainer { + public static final Logger LOG = LoggerFactory.getLogger(StarRocksContainer.class); + + public static final String DEFAULT_IMAGE = "starrocks/allin1-ubuntu:3.3-latest"; + public static final String HOST_NAME = "gravitino-ci-starrocks"; + public static final String USER_NAME = "root"; + public static final String PASSWORD = ""; + public static final int FE_HTTP_PORT = 8030; + public static final int FE_MYSQL_PORT = 9030; + + private static final String STARROCKS_FE_PATH = "/opt/apache-starrocks/fe/log"; Review Comment: Starrocks is not an Apache project, you can change it to other name. ########## catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/config/JdbcConfig.java: ########## @@ -65,7 +66,7 @@ public class JdbcConfig extends Config { .doc("The password of the Jdbc connection") .version(ConfigConstants.VERSION_0_3_0) .stringConf() - .checkValue(StringUtils::isNotBlank, ConfigConstants.NOT_BLANK_ERROR_MSG) + .checkValue(Objects::nonNull, ConfigConstants.NOT_BLANK_ERROR_MSG) Review Comment: I am very confused about why we need to make this change. ########## core/src/main/java/org/apache/gravitino/Config.java: ########## @@ -198,7 +198,7 @@ public void loadFromMap(Map<String, String> map, Predicate<String> predicate) { (k, v) -> { String trimmedK = k.trim(); String trimmedV = v.trim(); - if (!trimmedK.isEmpty() && !trimmedV.isEmpty()) { + if (!trimmedK.isEmpty()) { Review Comment: Also here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
