jerryshao commented on code in PR #7850: URL: https://github.com/apache/gravitino/pull/7850#discussion_r2262241891
########## core/src/main/java/org/apache/gravitino/stats/storage/PartitionStatisticStorage.java: ########## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.stats.storage; + +import com.google.common.collect.Lists; +import java.io.Closeable; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; +import org.apache.gravitino.MetadataObject; +import org.apache.gravitino.stats.PartitionRange; +import org.apache.gravitino.stats.PartitionStatisticsDrop; +import org.apache.gravitino.stats.PartitionStatisticsUpdate; +import org.apache.gravitino.stats.StatisticValue; + +/** Interface for managing partition statistics in a storage system. */ +public interface PartitionStatisticStorage extends Closeable { + + /** + * Returns the name of the metalake associated with this storage. + * + * @return the name of the metalake + */ + String metalake(); + + /** + * Returns the properties of this storage. + * + * @return a map of properties associated with this storage. + */ + Map<String, String> properties(); Review Comment: It is weird you want the implementor to provide you a metalake and properties. If you're an implementor, how do you provide these? This is anti-intuitive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
