justinmclean opened a new issue, #8034:
URL: https://github.com/apache/gravitino/issues/8034

   ### What would you like to be improved?
   
   Improve api/src/main/java/org/apache/gravitino/rel/types/Types.java to fully 
suport nallable simpleStrings.
   
   Some test code:
   ```
       Types.MapType mapTypeNotNull =
           Types.MapType.valueNotNull(Types.IntegerType.get(), 
Types.StringType.get());
       Assertions.assertEquals(Type.Name.MAP, mapTypeNotNull.name());
       Assertions.assertEquals(Types.IntegerType.get(), 
mapTypeNotNull.keyType());
       Assertions.assertEquals(Types.StringType.get(), 
mapTypeNotNull.valueType());
       Assertions.assertEquals("map<integer,string, NOT NULL>", 
mapTypeNotNull.simpleString());
       Assertions.assertEquals(
           mapTypeNotNull,
           Types.MapType.valueNotNull(Types.IntegerType.get(), 
Types.StringType.get()));
   ```
   
   ### How should we improve?
   
   Change the simpleString method so that the returned string reflects whether 
the map’s values are nullable or not, appending NOT NULL when appropriate


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to