hqbhoho commented on code in PR #7820:
URL: https://github.com/apache/gravitino/pull/7820#discussion_r2278068413
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java:
##########
@@ -126,6 +127,9 @@ public class GravitinoConfig {
"false",
false);
+ private static final ConfigEntry GRAVITINO_CLIENT_CONFIG_PREFIX =
+ new ConfigEntry("gravitino.client.", "The config prefix for Grivitino
client", "", false);
+
Review Comment:
All check exist in `GravitinoClientConfiguration` in `client-java` like this:
```
public static GravitinoClientConfiguration buildFromProperties(Map<String,
String> properties) {
for (String key : properties.keySet()) {
if (!SUPPORT_CLIENT_CONFIG_KEYS.contains(key)) {
throw new IllegalArgumentException(String.format("Invalid property
for client: %s", key));
}
}
return new GravitinoClientConfiguration(properties);
}
```
So connector will not need check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
