hqbhoho commented on code in PR #8258:
URL: https://github.com/apache/gravitino/pull/8258#discussion_r2318427796


##########
integration-test-common/docker-script/init/hive/init.sql:
##########
@@ -0,0 +1,30 @@
+CREATE DATABASE gt_hive_test_acid;
+SET hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
+SET hive.support.concurrency=true;
+CREATE TABLE gt_hive_test_acid.test_update
+(
+    id INT,
+    name STRING,
+    salary INT
+)
+CLUSTERED BY (id) INTO 4 BUCKETS
+STORED AS ORC
+TBLPROPERTIES ('transactional'='true');
+CREATE TABLE gt_hive_test_acid.test_delete
+(
+    id INT,
+    name STRING,
+    salary INT
+)
+CLUSTERED BY (id) INTO 4 BUCKETS
+STORED AS ORC
+TBLPROPERTIES ('transactional'='true');
+CREATE TABLE gt_hive_test_acid.test_merge
+(
+    id INT,
+    name STRING,
+    salary INT
+)
+CLUSTERED BY (id) INTO 4 BUCKETS
+STORED AS ORC
+TBLPROPERTIES ('transactional'='true');

Review Comment:
   Currently, it can't create a hive ACID table like this: 
   ```sql
   CREATE TABLE tb01 (
       n_nationkey bigint,
       n_name varchar,
       n_regionkey bigint,
       n_comment varchar,
       part_key varchar
   ) WITH (bucket_count = 4, bucketed_by = ARRAY['n_regionkey'], transactional 
= 'true', format = 'ORC');
   
   Expect:
   CREATE TABLE
   Actual:
   Query 20250903_094457_00270_ajycf failed: Catalog 'gt_hive' table property 
'transactional' does not exist.
   ```
   
   Considering that ACID tables in Hive are not widely used, I feel it's 
unnecessary to support their creation in Gravitino for now.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to