This is an automated email from the ASF dual-hosted git repository.

jshao pushed a commit to branch branch-1.0
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/branch-1.0 by this push:
     new b1d1757d47 [#8435] feat(iceberg): passing s3.path-style-access to the 
client side in Iceberg REST server (#8449)
b1d1757d47 is described below

commit b1d1757d47bb9e79359759576a788d62fb0dec55
Author: github-actions[bot] 
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Fri Sep 5 19:53:01 2025 +0800

    [#8435] feat(iceberg): passing s3.path-style-access to the client side in 
Iceberg REST server (#8449)
    
    ### What changes were proposed in this pull request?
    
    passing s3.path-style-access to the client side in Iceberg REST server
    
    ### Why are the changes needed?
    
    Fix: #8435
    
    ### Does this PR introduce _any_ user-facing change?
    no
    
    ### How was this patch tested?
    adding UT
    
    Co-authored-by: FANNG <[email protected]>
---
 .../org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java   | 3 ++-
 .../apache/gravitino/iceberg/service/rest/IcebergRestTestUtil.java    | 4 ++++
 .../org/apache/gravitino/iceberg/service/rest/TestIcebergConfig.java  | 4 +++-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git 
a/iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java
 
b/iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java
index e3d6542f0c..ffe38661cd 100644
--- 
a/iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java
+++ 
b/iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java
@@ -59,7 +59,8 @@ public class CatalogWrapperForREST extends 
IcebergCatalogWrapper {
           IcebergConstants.IO_IMPL,
           IcebergConstants.AWS_S3_REGION,
           IcebergConstants.ICEBERG_S3_ENDPOINT,
-          IcebergConstants.ICEBERG_OSS_ENDPOINT);
+          IcebergConstants.ICEBERG_OSS_ENDPOINT,
+          IcebergConstants.ICEBERG_S3_PATH_STYLE_ACCESS);
 
   @SuppressWarnings("deprecation")
   private static Map<String, String> deprecatedProperties =
diff --git 
a/iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/IcebergRestTestUtil.java
 
b/iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/IcebergRestTestUtil.java
index 7cfa4cc6fc..0a50a7374e 100644
--- 
a/iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/IcebergRestTestUtil.java
+++ 
b/iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/IcebergRestTestUtil.java
@@ -122,6 +122,10 @@ public class IcebergRestTestUtil {
       catalogConf.put(
           String.format("%s.%s", catalogConfigPrefix, 
IcebergConstants.ICEBERG_OSS_ENDPOINT),
           "https://oss-endpoint.example.com";);
+      catalogConf.put(
+          String.format(
+              "%s.%s", catalogConfigPrefix, 
IcebergConstants.ICEBERG_S3_PATH_STYLE_ACCESS),
+          "true");
       IcebergConfigProvider configProvider = 
IcebergConfigProviderFactory.create(catalogConf);
       configProvider.initialize(catalogConf);
       // used to override register table interface
diff --git 
a/iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergConfig.java
 
b/iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergConfig.java
index 04ac0cab10..58103e52b7 100644
--- 
a/iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergConfig.java
+++ 
b/iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergConfig.java
@@ -88,7 +88,9 @@ public class TestIcebergConfig extends IcebergTestBase {
             IcebergConstants.AWS_S3_REGION,
             "us-west-2",
             IcebergConstants.ICEBERG_OSS_ENDPOINT,
-            "https://oss-endpoint.example.com";);
+            "https://oss-endpoint.example.com";,
+            IcebergConstants.ICEBERG_S3_PATH_STYLE_ACCESS,
+            "true");
     Assertions.assertEquals(expectedConfig, response.defaults());
     Assertions.assertEquals(0, response.overrides().size());
   }

Reply via email to