predator4ann commented on code in PR #8216:
URL: https://github.com/apache/gravitino/pull/8216#discussion_r2324608733


##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/hive/HiveDataTypeTransformer.java:
##########
@@ -72,6 +75,10 @@ public Type getGravitinoType(io.trino.spi.type.Type type) {
       }
 
       return Types.FixedCharType.of(charType.getLength());
+    } else if 
(io.trino.spi.type.TimestampType.class.isAssignableFrom(typeClass)) {
+      // When creating a table in Hive, the timestamp data type only supports 
not specifying
+      // precision, with the default precision being 3 (milliseconds precision)
+      return Types.TimestampType.withoutTimeZone();

Review Comment:
   When creating a Hive table via Trino, only timestamp and timestamp(3) are 
accepted, and the ultimately mapped Hive data type is always timestamp(3). 
Other types will result in an error. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to