pandeysambhi opened a new pull request, #8455:
URL: https://github.com/apache/gravitino/pull/8455
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Add a null check before shutting down scheduledExecutorService in close
method.
### Why are the changes needed?
clientPoolCache is a static field, meaning it is shared across all instances
of IcebergHiveCachedClientPool.
Only the first instance that calls init() will initialize both
clientPoolCache and scheduledExecutorService.
Any subsequent instances will find clientPoolCache already initialized, so
they will not initialize scheduledExecutorService (it remains null for those
instances).When we create multiple instances of IcebergHiveCachedClientPool,
only the first instance will have a non-null scheduledExecutorService.The other
instances will have scheduledExecutorService as null.
When we call close() on all instances, each will attempt to call
scheduledExecutorService.shutdownNow()
For instances where scheduledExecutorService is null, this results in a
NullPointerException.
Fix: (#8382 )
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
unit testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
