tsungchih commented on code in PR #8458: URL: https://github.com/apache/gravitino/pull/8458#discussion_r2333838366
########## clients/client-python/gravitino/dto/rel/json_serdes/distribution_serdes.py: ########## @@ -0,0 +1,55 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +from typing import Any + +from gravitino.api.expressions.distributions.strategy import Strategy +from gravitino.api.types.json_serdes.base import JsonSerializable +from gravitino.dto.rel.distribution_dto import DistributionDTO +from gravitino.dto.rel.expressions.json_serdes._helper.serdes_utils import SerdesUtils +from gravitino.utils.precondition import Precondition +from gravitino.utils.serdes import SerdesUtilsBase + + +class DistributionSerDes(SerdesUtilsBase, JsonSerializable[DistributionDTO]): + """Custom JSON deserializer for DistributionDTO objects.""" + + @classmethod + def serialize(cls, data_type: DistributionDTO) -> dict[str, Any]: Review Comment: @jerryshao Yes, definitely. With the "TableDTO" you mentioned, the equivalent role has shown in the unit tests, `MockDataClass`. Since we're using `dataclasses-json` for serdes, the serdes for nested fields are handled by the library if and only if the class is decorated by `@dataclass_json` or extends `DataClassJsonMixin`. Therefore, we may have the "TableDTO" be declared as follows. ```python from dataclasses import dataclass, field from dataclasses_json import DataClassJsonMixin, config from gravitino.dto.rel.indexes.json_serdes.index_serdes import IndexSerdes from gravitino.dto.rel.json_serdes.distribution_serdes import DistributionSerDes @dataclass class TableDTO(DataclassJsonMixin): name: str comment: str ... ... distribution: DistributionDTO = field( metadata=config( encoder=DistributionSerdes.serialize, decoder=DistributionSerdes.deserialize, ) ) indexes: list[IndexDTO] = field( metadata=config( encoder=lambda idxs: [IndexSerdes.serialize(idx) for idx in idxs], decoder=lambda idxs: [IndexSerdes.deserialize(idx) for idx in idxs], ) ) ... ... ``` After the server has received the JSON string, say `json_string`, we should be able to deserialize the string by means of `table_dto = TableDTO.from_json(json_string)`. We can then serialize a `table_dto` using `json_string = table_dto.to_json()`. Hope this explanation answers your question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
