jerqi commented on code in PR #8450: URL: https://github.com/apache/gravitino/pull/8450#discussion_r2335927225
########## docs/manage-statistics-in-gravitino.md: ########## @@ -245,13 +245,16 @@ For example, if you set an extra property `foo` to `bar` for Lance storage optio For Lance remote storage, you can refer to the document [here](https://lancedb.github.io/lance/usage/storage/). -| Configuration item | Description | Default value | Required | Since version | -|-----------------------------------------------------------|--------------------------------------|--------------------------------|-------------------------------------------------|---------------| -| `gravitino.stats.partition.storageOption.location` | The location of Lance files | `${GRAVITINO_HOME}/data/lance` | No | 1.0.0 | -| `gravitino.stats.partition.storageOption.maxRowsPerFile` | The maximum rows per file | `1000000` | No | 1.0.0 | -| `gravitino.stats.partition.storageOption.maxBytesPerFile` | The maximum bytes per file | `104857600` | No | 1.0.0 | -| `gravitino.stats.partition.storageOption.maxRowsPerGroup` | The maximum rows per group | `1000000` | No | 1.0.0 | -| `gravitino.stats.partition.storageOption.readBatchSize` | The batch record number when reading | `10000` | No | 1.0.0 | +| Configuration item | Description | Default value | Required | Since version | +|----------------------------------------------------------------------|--------------------------------------|--------------------------------|-------------------------------------------------|---------------| Review Comment: No, I can't. It will break the style. ########## docs/manage-statistics-in-gravitino.md: ########## @@ -245,13 +245,16 @@ For example, if you set an extra property `foo` to `bar` for Lance storage optio For Lance remote storage, you can refer to the document [here](https://lancedb.github.io/lance/usage/storage/). -| Configuration item | Description | Default value | Required | Since version | -|-----------------------------------------------------------|--------------------------------------|--------------------------------|-------------------------------------------------|---------------| -| `gravitino.stats.partition.storageOption.location` | The location of Lance files | `${GRAVITINO_HOME}/data/lance` | No | 1.0.0 | -| `gravitino.stats.partition.storageOption.maxRowsPerFile` | The maximum rows per file | `1000000` | No | 1.0.0 | -| `gravitino.stats.partition.storageOption.maxBytesPerFile` | The maximum bytes per file | `104857600` | No | 1.0.0 | -| `gravitino.stats.partition.storageOption.maxRowsPerGroup` | The maximum rows per group | `1000000` | No | 1.0.0 | -| `gravitino.stats.partition.storageOption.readBatchSize` | The batch record number when reading | `10000` | No | 1.0.0 | +| Configuration item | Description | Default value | Required | Since version | +|----------------------------------------------------------------------|--------------------------------------|--------------------------------|-------------------------------------------------|---------------| +| `gravitino.stats.partition.storageOption.location` | The location of Lance files | `${GRAVITINO_HOME}/data/lance` | No | 1.0.0 | +| `gravitino.stats.partition.storageOption.maxRowsPerFile` | The maximum rows per file | `1000000` | No | 1.0.0 | +| `gravitino.stats.partition.storageOption.maxBytesPerFile` | The maximum bytes per file | `104857600` | No | 1.0.0 | +| `gravitino.stats.partition.storageOption.maxRowsPerGroup` | The maximum rows per group | `1000000` | No | 1.0.0 | +| `gravitino.stats.partition.storageOption.readBatchSize` | The batch record number when reading | `10000` | No | 1.0.0 | +| `gravitino.stats.partition.storageOption.datasetCacheSize` | The dataset of Lance cache size | `10000` | No | 1.0.0 | Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
