(gravitino) branch branch-1.0 updated: [#8484] Improvement(trino):JDBCCatalogPropertyConverter.java converter where the required property set mistakenly includes the password key twice (#8503)

[jshao]

This is an automated email from the ASF dual-hosted git repository.

jshao pushed a commit to branch branch-1.0
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/branch-1.0 by this push:
     new 6c2ee98dd4 [#8484] 
Improvement(trino):JDBCCatalogPropertyConverter.java converter where the 
required property set mistakenly includes the password key twice (#8503)
6c2ee98dd4 is described below

commit 6c2ee98dd4e5e08f65905bfd31dc1ad24b028092
Author: github-actions[bot] 
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Thu Sep 11 10:01:53 2025 +0800

    [#8484] Improvement(trino):JDBCCatalogPropertyConverter.java converter 
where the required property set mistakenly includes the password key twice 
(#8503)
    
    ### What changes were proposed in this pull request?
    
    JDBCCatalogPropertyConverter.java converter where the required property
    set mistakenly includes the password key twice
    
    ### Why are the changes needed?
    
    
    Fix: #8484
    
    ### Does this PR introduce _any_ user-facing change?
    
    N/A
    
    ### How was this patch tested?
    
    
    
org.apache.gravitino.trino.connector.catalog.jdbc.TestJDBCCatalogPropertyConverter#testMissingConnectionUrl
    
    Co-authored-by: Xiaojian Sun <sunxiaojian...@163.com>
---
 .../catalog/jdbc/JDBCCatalogPropertyConverter.java          |  2 +-
 .../catalog/jdbc/TestJDBCCatalogPropertyConverter.java      | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git 
a/trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/jdbc/JDBCCatalogPropertyConverter.java
 
b/trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/jdbc/JDBCCatalogPropertyConverter.java
index 6d438a3e53..01b5c52e76 100644
--- 
a/trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/jdbc/JDBCCatalogPropertyConverter.java
+++ 
b/trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/jdbc/JDBCCatalogPropertyConverter.java
@@ -56,7 +56,7 @@ public class JDBCCatalogPropertyConverter extends 
CatalogPropertyConverter {
   /** Set of required properties for JDBC connection. */
   public static final Set<String> REQUIRED_PROPERTIES =
       Sets.newHashSet(
-          JDBC_CONNECTION_PASSWORD_KEY, JDBC_CONNECTION_USER_KEY, 
JDBC_CONNECTION_PASSWORD_KEY);
+          JDBC_CONNECTION_URL_KEY, JDBC_CONNECTION_USER_KEY, 
JDBC_CONNECTION_PASSWORD_KEY);
 
   @Override
   public TreeBidiMap<String, String> engineToGravitinoMapping() {
diff --git 
a/trino-connector/trino-connector/src/test/java/org/apache/gravitino/trino/connector/catalog/jdbc/TestJDBCCatalogPropertyConverter.java
 
b/trino-connector/trino-connector/src/test/java/org/apache/gravitino/trino/connector/catalog/jdbc/TestJDBCCatalogPropertyConverter.java
index 32fa27c219..f0de36914a 100644
--- 
a/trino-connector/trino-connector/src/test/java/org/apache/gravitino/trino/connector/catalog/jdbc/TestJDBCCatalogPropertyConverter.java
+++ 
b/trino-connector/trino-connector/src/test/java/org/apache/gravitino/trino/connector/catalog/jdbc/TestJDBCCatalogPropertyConverter.java
@@ -58,4 +58,17 @@ public class TestJDBCCatalogPropertyConverter {
           
propertyConverter.gravitinoToEngineProperties(gravitinoPropertiesWithoutPassword);
         });
   }
+
+  @Test
+  public void testMissingConnectionUrl() {
+    PropertyConverter propertyConverter = new JDBCCatalogPropertyConverter();
+    Map<String, String> gravitinoPropertiesWithoutUrl =
+        ImmutableMap.of("jdbc-user", "root", "jdbc-password", "root");
+
+    Assertions.assertThrows(
+        IllegalArgumentException.class,
+        () -> {
+          
propertyConverter.gravitinoToEngineProperties(gravitinoPropertiesWithoutUrl);
+        });
+  }
 }