agnes-xinyi-lu commented on code in PR #8189:
URL: https://github.com/apache/gravitino/pull/8189#discussion_r2360793243
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ClosableHiveCatalog.java:
##########
@@ -60,4 +74,120 @@ public void close() throws IOException {
}
});
}
+
+ @FunctionalInterface
+ interface Executable<R> {
+ R run() throws Exception;
+ }
+
+ public <R> R execute(Executable<R> runnable) {
+ try {
+ return runnable.run();
+ } catch (Exception e) {
+ LOGGER.error("Failed to execute runnable: {}", runnable, e);
+ if (e instanceof RuntimeException) {
+ throw (RuntimeException) e;
+ }
+
+ throw new RuntimeException(e);
+ }
+ }
+
+ // public Catalog.TableBuilder buildTable(TableIdentifier identifier,
Schema schema) {
+ // ExtendedViewAwareTableBuilderExtended builder =
+ // new ExtendedViewAwareTableBuilderExtended(identifier, schema);
+ // ViewAwareTableBuilderProxy proxy =
+ // new ViewAwareTableBuilderProxy(builder, this.proxy != null ?
this.proxy : this);
+ // ExtendedViewAwareTableBuilderExtended r =
+ // proxy.getProxy(new Object[] {this, identifier, schema});
+ // return r;
+ // }
+
+ public static class ViewAwareTableBuilderProxy implements MethodInterceptor {
Review Comment:
are these still needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
