This is an automated email from the ASF dual-hosted git repository.

yuqi4733 pushed a commit to branch branch-1.0
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/branch-1.0 by this push:
     new 3fecb1cb3a [MINOR] fix(release): dev/release/release-build.sh You need 
a space before the ]. shellcheckSC1020 (#8631)
3fecb1cb3a is described below

commit 3fecb1cb3a38b3a635acf5d9e5ac32dd3bfe1803
Author: github-actions[bot] 
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Fri Sep 19 23:10:27 2025 +0800

    [MINOR] fix(release): dev/release/release-build.sh You need a space before 
the ]. shellcheckSC1020 (#8631)
    
    [Minor] dev/release/release-build.sh You need a space before the
    ].shellcheckSC1020
    
    <!--
    1. Title: [#<issue>] <type>(<scope>): <subject>
       Examples:
         - "[#123] feat(operator): support xxx"
         - "[#233] fix: check null before access result in xxx"
         - "[MINOR] refactor: fix typo in variable name"
         - "[MINOR] docs: fix typo in README"
         - "[#255] test: fix flaky test NameOfTheTest"
       Reference: https://www.conventionalcommits.org/en/v1.0.0/
    2. If the PR is unfinished, please mark this PR as draft.
    -->
    
    ### What changes were proposed in this pull request?
    
    <https://www.shellcheck.net/wiki/SC1020>
    
    ```bash
    if [ -z "$PYGRAVITINO_VERSION"];
    ```
    
    ```bash
    if [ -z "$PYGRAVITINO_VERSION" ];
    ```
    
    
    You need a space before the ] or ]]
    Problematic code:
    ```bash
    if [ "$STUFF" = ""]; then
    ```
    Correct code:
    ```bash
    if [ "$STUFF" = "" ]; then
    ```
    Rationale:
    
    Bourne shells are very whitespace sensitive. Adding or removing spaces
    can drastically alter the meaning of a script. In these cases,
    ShellCheck has noticed that you're missing a space at the position
    indicated.
    
    
    
    ### Why are the changes needed?
    
    Bourne shells are very whitespace sensitive. Adding or removing spaces
    can drastically alter the meaning of a script. In these cases,
    ShellCheck has noticed that you're missing a space at the position
    indicated.
    
    Fix: #(issue)
    
    ### Does this PR introduce _any_ user-facing change?
    ### How was this patch tested?
    
    Co-authored-by: dyrnq <[email protected]>
---
 dev/release/release-build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dev/release/release-build.sh b/dev/release/release-build.sh
index 6393480708..a27079b28e 100755
--- a/dev/release/release-build.sh
+++ b/dev/release/release-build.sh
@@ -170,7 +170,7 @@ if [ -z "$GRAVITINO_VERSION" ]; then
   GRAVITINO_VERSION=$(cat gradle.properties | parse_version)
 fi
 
-if [ -z "$PYGRAVITINO_VERSION"]; then
+if [ -z "$PYGRAVITINO_VERSION" ]; then
   PYGRAVITINO_VERSION=$(cat clients/client-python/setup.py | grep "version=" | 
awk -F"\"" '{print $2}')
 fi
 

Reply via email to