justinmclean commented on PR #8738: URL: https://github.com/apache/gravitino/pull/8738#issuecomment-3353940283
Thanks for the unit tests and changes, however, changing checkNotNull to checkArgument wasn't what I had in mind. To be more explicit: For RenameTableRequest - If a new schema name is provided, it must not be blank. (Currently allowed to be "".) For AddTableIndexRequest - Validate index.name() is not blank (currently only type and fieldNames are checked). You might also want to validate that inner fieldNames arrays contain only non-blank field path segments. For DeleteTableIndexRequest - validate() only checks name != null. Should be not blank to avoid empty string. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
