mchades commented on code in PR #8963:
URL: https://github.com/apache/gravitino/pull/8963#discussion_r2476750602
##########
lance/lance-common/src/test/java/org/apache/gravitino/lance/common/ops/gravitino/TestLanceDataTypeConverter.java:
##########
@@ -270,10 +275,11 @@ void testUnsupportedTypeThrowsException() {
assertThrows(UnsupportedOperationException.class, () ->
CONVERTER.fromGravitino(unparsedType));
}
- @Test
- void testToGravitinoNotImplemented() {
- assertThrows(
- UnsupportedOperationException.class, () ->
CONVERTER.toGravitino(ArrowType.Utf8.INSTANCE));
+ @ParameterizedTest(name = "[{index}] {0}")
+ @MethodSource("toGravitinoArguments")
+ void testToGravitino(String testName, Field arrowField, Type
expectedGravitinoType) {
+ Type convertedType = CONVERTER.toGravitino(arrowField);
+ assertEquals(expectedGravitinoType, convertedType);
Review Comment:
They will not be equal because they have different return types (plz see the
method signature). What's more, there are already UTs for these two methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
