jerryshao commented on code in PR #8964:
URL: https://github.com/apache/gravitino/pull/8964#discussion_r2480296487
##########
lance/lance-rest-server/src/main/java/org/apache/gravitino/lance/service/rest/LanceTableOperations.java:
##########
@@ -81,11 +91,15 @@ public Response createTable(
@PathParam("id") String tableId,
@QueryParam("mode") @DefaultValue("create") String mode, // create,
exist_ok, overwrite
@QueryParam("delimiter") @DefaultValue(NAMESPACE_DELIMITER_DEFAULT)
String delimiter,
- @HeaderParam("x-lance-table-location") String tableLocation,
- @HeaderParam("x-lance-table-properties") String tableProperties,
- @HeaderParam("x-lance-root-catalog") String rootCatalog,
Review Comment:
We'd better not leverage something that is in the header and only used in
one or two clients; we should not make such an assumption. Can we confirm with
the Lance guy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
