Copilot commented on code in PR #9147:
URL: https://github.com/apache/gravitino/pull/9147#discussion_r2558792324
##########
docs/fileset-catalog-with-adls.md:
##########
@@ -280,14 +280,12 @@ If your wants to custom your hadoop version or there is
already a hadoop version
<artifactId>gravitino-filesystem-hadoop3-runtime</artifactId>
<version>${GRAVITINO_VERSION}</version>
</dependency>
-
- <dependency>
- <groupId>org.apache.gravitino</groupId>
- <artifactId>gravitino-azure</artifactId>
- <version>${GRAVITINO_VERSION}</version>
- </dependency>
```
+:::note
+Since version 1.1.0, the `gravitino-azure` JAR is no longer required, as it is
now included in the `gravitino-filesystem-hadoop3-runtime` JAR.
Review Comment:
[nitpick] The note mentions "Since version 1.1.0" but it should be verified
that this is the correct version number for this change. If this PR is
introducing the change, the version should match the upcoming release version.
```suggestion
Since version ${GRAVITINO_VERSION}, the `gravitino-azure` JAR is no longer
required, as it is now included in the `gravitino-filesystem-hadoop3-runtime`
JAR.
```
##########
bundles/aws-bundle/build.gradle.kts:
##########
@@ -51,7 +54,6 @@ tasks.withType(ShadowJar::class.java) {
relocate("org.checkerframework",
"org.apache.gravitino.aws.shaded.org.checkerframework")
relocate("org.reactivestreams",
"org.apache.gravitino.aws.shaded.org.reactivestreams")
relocate("org.wildfly.openssl",
"org.apache.gravitino.aws.shaded.org.wildfly.openssl")
Review Comment:
The relocation directive for `software.amazon` has been removed, but this
package is still present in the AWS SDK dependencies that are being shaded.
This could lead to class conflicts with other libraries that use AWS SDK. The
relocation should be kept to ensure proper shading of AWS SDK packages.
```suggestion
relocate("org.wildfly.openssl",
"org.apache.gravitino.aws.shaded.org.wildfly.openssl")
relocate("software.amazon",
"org.apache.gravitino.aws.shaded.software.amazon")
```
##########
docs/fileset-catalog-with-gcs.md:
##########
@@ -271,14 +271,12 @@ If your wants to custom your hadoop version or there is
already a hadoop version
<artifactId>gravitino-filesystem-hadoop3-runtime</artifactId>
<version>${GRAVITINO_VERSION}</version>
</dependency>
-
- <dependency>
- <groupId>org.apache.gravitino</groupId>
- <artifactId>gravitino-gcp</artifactId>
- <version>${GRAVITINO_VERSION}</version>
- </dependency>
```
+:::note
+Since version 1.1.0, the `gravitino-gcp` JAR is no longer required, as it is
now included in the `gravitino-filesystem-hadoop3-runtime` JAR.
Review Comment:
[nitpick] The note mentions "Since version 1.1.0" but it should be verified
that this is the correct version number for this change. If this PR is
introducing the change, the version should match the upcoming release version.
```suggestion
Since version ${GRAVITINO_VERSION}, the `gravitino-gcp` JAR is no longer
required, as it is now included in the `gravitino-filesystem-hadoop3-runtime`
JAR.
```
##########
docs/fileset-catalog-with-s3.md:
##########
@@ -370,7 +368,7 @@ os.environ["PYSPARK_SUBMIT_ARGS"] = "--jars
/path/to/gravitino-aws-bundle-${grav
```
-
[`gravitino-aws-bundle-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-aws-bundle)
is the Gravitino AWS jar with Hadoop environment(3.3.1) and `hadoop-aws` jar.
--
[`gravitino-aws-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-aws)
is a condensed version of the Gravitino AWS bundle jar without Hadoop
environment and `hadoop-aws` jar.
+-
[`gravitino-aws-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-aws)
is bundled with the
`gravitino-filesystem-hadoop3-runtime-${gravitino-version}.jar` and
`gravitino-aws-bundle-${gravitino-version}.jar` since version 1.1.0.
Review Comment:
[nitpick] The text mentions "since version 1.1.0" but it should be verified
that this is the correct version number for this change. If this PR is
introducing the change, the version should match the upcoming release version.
```suggestion
-
[`gravitino-aws-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-aws)
is bundled with the
`gravitino-filesystem-hadoop3-runtime-${gravitino-version}.jar` and
`gravitino-aws-bundle-${gravitino-version}.jar` since version
${gravitino-version}.
```
##########
docs/fileset-catalog-with-oss.md:
##########
@@ -375,7 +373,7 @@ os.environ["PYSPARK_SUBMIT_ARGS"] = "--jars
/path/to/gravitino-aliyun-bundle-{gr
```
-
[`gravitino-aliyun-bundle-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-aliyun-bundle)
is the Gravitino Aliyun jar with Hadoop environment(3.3.1) and `hadoop-oss`
jar.
--
[`gravitino-aliyun-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-aliyun)
is a condensed version of the Gravitino Aliyun bundle jar without Hadoop
environment and `hadoop-aliyun` jar.
+-
[`gravitino-aliyun-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-aliyun)
is bundled with the
`gravitino-filesystem-hadoop3-runtime-${gravitino-version}.jar` and
`gravitino-aliyun-bundle-${gravitino-version}.jar` since version 1.1.0.
Review Comment:
[nitpick] The text mentions "since version 1.1.0" but it should be verified
that this is the correct version number for this change. If this PR is
introducing the change, the version should match the upcoming release version.
```suggestion
-
[`gravitino-aliyun-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-aliyun)
is bundled with the
`gravitino-filesystem-hadoop3-runtime-${gravitino-version}.jar` and
`gravitino-aliyun-bundle-${gravitino-version}.jar` since version
`${gravitino-version}`.
```
##########
docs/fileset-catalog-with-oss.md:
##########
@@ -286,14 +286,12 @@ If your wants to custom your hadoop version or there is
already a hadoop version
<artifactId>gravitino-filesystem-hadoop3-runtime</artifactId>
<version>${GRAVITINO_VERSION}</version>
</dependency>
-
- <dependency>
- <groupId>org.apache.gravitino</groupId>
- <artifactId>gravitino-aliyun</artifactId>
- <version>${GRAVITINO_VERSION}</version>
- </dependency>
```
+:::note
+Since version 1.1.0, the `gravitino-aliyun` JAR is no longer required, as it
is now included in the `gravitino-filesystem-hadoop3-runtime` JAR.
Review Comment:
[nitpick] The note mentions "Since version 1.1.0" but it should be verified
that this is the correct version number for this change. If this PR is
introducing the change, the version should match the upcoming release version.
```suggestion
Since version 1.2.0, the `gravitino-aliyun` JAR is no longer required, as it
is now included in the `gravitino-filesystem-hadoop3-runtime` JAR.
```
##########
docs/fileset-catalog-with-gcs.md:
##########
@@ -366,7 +364,7 @@ os.environ["PYSPARK_SUBMIT_ARGS"] = (
```
-
[`gravitino-gcp-bundle-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-gcp-bundle)
is the Gravitino GCP jar with Hadoop environment(3.3.1) and `gcs-connector`.
--
[`gravitino-gcp-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-gcp)
is a condensed version of the Gravitino GCP bundle jar without Hadoop
environment and
[`gcs-connector`](https://github.com/GoogleCloudDataproc/hadoop-connectors/releases/download/v2.2.22/gcs-connector-hadoop3-2.2.22-shaded.jar)
+-
[`gravitino-gcp-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-gcp)
is bundled with the
`gravitino-filesystem-hadoop3-runtime-${gravitino-version}.jar` and
`gravitino-gcp-bundle-${gravitino-version}.jar` since version 1.1.0.
Review Comment:
[nitpick] The text mentions "since version 1.1.0" but it should be verified
that this is the correct version number for this change. If this PR is
introducing the change, the version should match the upcoming release version.
```suggestion
-
[`gravitino-gcp-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-gcp)
is bundled with the
`gravitino-filesystem-hadoop3-runtime-${gravitino-version}.jar` and
`gravitino-gcp-bundle-${gravitino-version}.jar` since version 1.2.0.
```
##########
docs/fileset-catalog-with-adls.md:
##########
@@ -375,7 +373,7 @@ os.environ["PYSPARK_SUBMIT_ARGS"] = (
```
-
[`gravitino-azure-bundle-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-azure-bundle)
is the Gravitino ADLS jar with Hadoop environment(3.3.1), `hadoop-azure.jar`
and all packages needed to access ADLS.
--
[`gravitino-azure-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-azure)
is a condensed version of the Gravitino ADLS bundle jar without Hadoop
environment and `hadoop-azure.jar`.
+-
[`gravitino-azure-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-azure)
is bundled with the
`gravitino-filesystem-hadoop3-runtime-${gravitino-version}.jar` and
`gravitino-azure-bundle-${gravitino-version}.jar` since version 1.1.0.
Review Comment:
[nitpick] The text mentions "since version 1.1.0" but it should be verified
that this is the correct version number for this change. If this PR is
introducing the change, the version should match the upcoming release version.
```suggestion
-
[`gravitino-azure-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-azure)
is bundled with the
`gravitino-filesystem-hadoop3-runtime-${gravitino-version}.jar` and
`gravitino-azure-bundle-${gravitino-version}.jar` since version
${upcoming-release-version}.
```
##########
docs/fileset-catalog-with-s3.md:
##########
@@ -288,14 +288,12 @@ Similar to Spark configurations, you need to add S3
(bundle) jars to the classpa
<artifactId>gravitino-filesystem-hadoop3-runtime</artifactId>
<version>${GRAVITINO_VERSION}</version>
</dependency>
-
- <dependency>
- <groupId>org.apache.gravitino</groupId>
- <artifactId>gravitino-aws</artifactId>
- <version>${GRAVITINO_VERSION}</version>
- </dependency>
```
+:::note
+Since version 1.1.0, the `gravitino-aws` JAR is no longer required, as it is
now included in the `gravitino-filesystem-hadoop3-runtime` JAR.
Review Comment:
[nitpick] The note mentions "Since version 1.1.0" but it should be verified
that this is the correct version number for this change. If this PR is
introducing the change, the version should match the upcoming release version.
```suggestion
Since version 1.2.0, the `gravitino-aws` JAR is no longer required, as it is
now included in the `gravitino-filesystem-hadoop3-runtime` JAR.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
