Copilot commented on code in PR #9147:
URL: https://github.com/apache/gravitino/pull/9147#discussion_r2570535273
##########
bundles/aws-bundle/build.gradle.kts:
##########
@@ -51,7 +64,6 @@ tasks.withType(ShadowJar::class.java) {
relocate("org.checkerframework",
"org.apache.gravitino.aws.shaded.org.checkerframework")
relocate("org.reactivestreams",
"org.apache.gravitino.aws.shaded.org.reactivestreams")
relocate("org.wildfly.openssl",
"org.apache.gravitino.aws.shaded.org.wildfly.openssl")
Review Comment:
The removal of the `software.amazon` relocation rule may cause runtime
conflicts with AWS SDK classes. The AWS IAM, STS, and Policy dependencies added
on lines 31-33 contain classes in the `software.amazon` package that should be
relocated to avoid conflicts with other AWS SDK versions that might be present
in the classpath. Consider restoring this relocation:
`relocate("software.amazon", "org.apache.gravitino.aws.shaded.software.amazon")`
```suggestion
relocate("org.wildfly.openssl",
"org.apache.gravitino.aws.shaded.org.wildfly.openssl")
relocate("software.amazon",
"org.apache.gravitino.aws.shaded.software.amazon")
```
##########
docs/lakehouse-iceberg-catalog.md:
##########
@@ -105,7 +107,11 @@ Gravitino Iceberg REST service supports using static
access-key-id and secret-ac
For other Iceberg OSS properties not managed by Gravitino like
`client.security-token`, you could config it directly by
`gravitino.bypass.client.security-token`.
:::info
-Please set the `warehouse` parameter to `oss://{bucket_name}/${prefix_name}`.
Additionally, download the [Aliyun OSS
SDK](https://gosspublic.alicdn.com/sdks/java/aliyun_java_sdk_3.10.2.zip) and
copy `aliyun-sdk-oss-3.10.2.jar`, `hamcrest-core-1.1.jar`, `jdom2-2.0.6.jar` in
the `catalogs/lakehouse-iceberg/libs/` directory.
+Please set the `warehouse` parameter to `oss://{bucket_name}/${prefix_name}`.
Additionally, download the [Gravitino Iceberg Aliyun
bundle](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-iceberg-aliyun-bundle)
and place it in the `catalogs/lakehouse-iceberg/libs/` directory.
+:::
+
+:::note
+Since Gravitino 1.1.0, the Gravitino Iceberg aliyun bundle jar have already
included the Iceberg aliyun necessary dependency jars, no need to download and
include them separately.
Review Comment:
Grammatical error: "have already included" should be "has already included"
to match the singular subject "jar".
```suggestion
Since Gravitino 1.1.0, the Gravitino Iceberg aliyun bundle jar has already
included the Iceberg aliyun necessary dependency jars, no need to download and
include them separately.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
