jerryshao commented on code in PR #9316:
URL: https://github.com/apache/gravitino/pull/9316#discussion_r2579458656
##########
build.gradle.kts:
##########
@@ -1181,5 +1181,13 @@ tasks.register("release") {
println("Releasing project...")
}
- dependsOn(subprojects.map { it.tasks.named("build") })
+ // Use 'assemble' instead of 'build' to skip tests during release
+ // Tests have JDK version conflicts (some need JDK 8, some need JDK 17)
+ // and should be run separately in CI/CD with appropriate JDK configurations
+ // Only include subprojects that apply the Java plugin (exclude
client-python)
+ dependsOn(
+ subprojects
+ .filter { it.name != "client-python" }
+ .map { it.tasks.named("assemble") }
+ )
Review Comment:
The first thing I want to fix is to make `./gradlew release` work without
error. Secondly, I think whether `release` should rely on `test` is arguable;
my feeling is that the purpose of `release` is to build jars for release, it is
not so necessary to run the `test` again. Since there's no better solution, I
think the current one is acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
