Copilot commented on code in PR #9557:
URL: https://github.com/apache/gravitino/pull/9557#discussion_r2652173991
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/RemoveModelVersionProperty.java:
##########
@@ -99,10 +99,10 @@ public void handle() {
}
if (alias != null) {
- printInformation(model + " alias " + alias + "property " + property + "
property removed.");
+ printInformation(model + " alias " + alias + " property " + property + "
property removed.");
Review Comment:
The output message contains redundant text with "property" appearing twice.
The message reads "model alias aliasA property key property removed." which
should likely be "model alias aliasA property key removed." Consider removing
one instance of "property" to improve message clarity.
##########
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/Column.java:
##########
@@ -29,7 +29,7 @@
*/
public class Column {
/** The character used to indicate that a cell has been truncated. */
- public static final char ELLIPSIS = '…';
+ public static final char ELLIPSIS = '\u2026';
Review Comment:
This change from character literal '…' to Unicode escape '\u2026' was not
mentioned in the PR description. While both represent the same ellipsis
character and the Unicode escape is more explicit, this appears to be an
unrelated change that should either be documented in the PR description or
submitted as a separate change. If this is intentional, please update the PR
description to explain why this change was made.
```suggestion
public static final char ELLIPSIS = '…';
```
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/RemoveModelVersionProperty.java:
##########
@@ -99,10 +99,10 @@ public void handle() {
}
if (alias != null) {
- printInformation(model + " alias " + alias + "property " + property + "
property removed.");
+ printInformation(model + " alias " + alias + " property " + property + "
property removed.");
} else {
printInformation(
- model + " version " + version + "property " + property + " property
removed.");
+ model + " version " + version + " property " + property + " property
removed.");
Review Comment:
The output message contains redundant text with "property" appearing twice.
The message reads "model version 1 property key property removed." which should
likely be "model version 1 property key removed." Consider removing one
instance of "property" to improve message clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
