jerryshao commented on code in PR #9483:
URL: https://github.com/apache/gravitino/pull/9483#discussion_r2654610604
##########
clients/client-python/gravitino/client/gravitino_metalake.py:
##########
@@ -293,7 +299,7 @@ def list_job_templates(self) -> List[JobTemplate]:
params = {"details": "true"}
url =
self.API_METALAKES_JOB_TEMPLATES_PATH.format(encode_string(self.name()))
response = self.rest_client.get(
- url, params=params, error_handler=JOB_ERROR_HANDLER
+ url, params=params, error_handler=ErrorHandlers.job_error_handler()
Review Comment:
If so, why do you only modify the job error handler, not others?
I'm not a Python expert, not sure which one is more pythonic. But my
strategy is that we don't have to align everything to Java. Instead, we should
follow more Python conventions. Python has its own convention, making it
Java-ish will be weird to the Python guys.
So my suggestion is that either we keep as it is. Or if necessary, we should
change them all.
CC @tsungchih what is your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
