mchades commented on code in PR #9574:
URL: https://github.com/apache/gravitino/pull/9574#discussion_r2666931268
##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -555,18 +541,14 @@ public void testConnection(
public void enableCatalog(NameIdentifier ident)
throws NoSuchCatalogException, CatalogNotInUseException {
NameIdentifier metalakeIdent =
NameIdentifier.of(ident.namespace().levels());
-
TreeLockUtils.doWithTreeLock(
metalakeIdent,
LockType.WRITE,
() -> {
- checkMetalake(metalakeIdent, store);
+ BaseCatalog baseCatalog = loadCatalogAndWrap(ident).catalog();
+ baseCatalog.checkMetalakeInUse();
Review Comment:
After this check, if `catalog-in-use` of the baseCatalog is true, can we
return directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
