yuqi1129 commented on code in PR #9631:
URL: https://github.com/apache/gravitino/pull/9631#discussion_r2667231140
##########
dev/release/release-tag.sh:
##########
@@ -125,21 +141,27 @@ echo "Creating tag $RELEASE_TAG at the head of
$GIT_BRANCH"
git tag $RELEASE_TAG
# Create next version
Review Comment:
Could you please add some comments here like 'Increase the chart version of
Gravitino', the sames goes for `ICR` and `LRC`.
##########
dev/release/release-tag.sh:
##########
@@ -125,21 +141,27 @@ echo "Creating tag $RELEASE_TAG at the head of
$GIT_BRANCH"
git tag $RELEASE_TAG
# Create next version
-sed -i".tmp11" 's/version = .*$/version = '"$NEXT_VERSION"'/g'
gradle.properties
-sed -i".tmp12" 's/ version=.*$/
version="'"$PYGRAVITINO_NEXT_VERSION"'",/g' clients/client-python/setup.py
-sed -i".tmp13" 's/^version = .*$/version = \"'"$NEXT_VERSION"'\"/g'
clients/filesystem-fuse/Cargo.toml
-sed -i".tmp14" 's/appVersion: .*$/appVersion: '"$NEXT_VERSION"'/g'
dev/charts/gravitino/Chart.yaml
-sed -i".tmp15" '34s/ tag: .*$/ tag: '"$NEXT_VERSION"'/'
dev/charts/gravitino/values.yaml
+sed -i".tmp14" 's/version = .*$/version = '"$NEXT_VERSION"'/g'
gradle.properties
+sed -i".tmp15" 's/ version=.*$/
version="'"$PYGRAVITINO_NEXT_VERSION"'",/g' clients/client-python/setup.py
+sed -i".tmp16" 's/^version = .*$/version = \"'"$NEXT_VERSION"'\"/g'
clients/filesystem-fuse/Cargo.toml
+sed -i".tmp17" 's/appVersion: .*$/appVersion: '"$NEXT_VERSION"'/g'
dev/charts/gravitino/Chart.yaml
+sed -i".tmp18" '34s/ tag: .*$/ tag: '"$NEXT_VERSION"'/g'
dev/charts/gravitino/values.yaml
CHART_REV=$((CHART_REV + 1))
NEXT_CHART_VERSION="${CHART_SHORT_VERSION}.${CHART_REV}"
-sed -i".tmp16" 's/^version: .*$/version: '"$NEXT_CHART_VERSION"'/g'
dev/charts/gravitino/Chart.yaml
+sed -i".tmp19" 's/^version: .*$/version: '"$NEXT_CHART_VERSION"'/g'
dev/charts/gravitino/Chart.yaml
IRC_CHART_REV=$((IRC_CHART_REV + 1))
NEXT_IRC_CHART_VERSION="${IRC_CHART_SHORT_VERSION}.${IRC_CHART_REV}"
-sed -i".tmp17" 's/appVersion: .*$/appVersion: '"$NEXT_VERSION"'/g'
dev/charts/gravitino-iceberg-rest-server/Chart.yaml
-sed -i".tmp18" '24s/ tag: .*$/ tag: '"$NEXT_VERSION"'/'
dev/charts/gravitino-iceberg-rest-server/values.yaml
-sed -i".tmp19" 's/^version: .*$/version: '"$NEXT_IRC_CHART_VERSION"'/g'
dev/charts/gravitino-iceberg-rest-server/Chart.yaml
-sed -i".tmp20" 's/^version = .*$/version = "'"$PYGRAVITINO_NEXT_VERSION"'"/g'
mcp-server/pyproject.toml
+sed -i".tmp20" 's/appVersion: .*$/appVersion: '"$NEXT_VERSION"'/g'
dev/charts/gravitino-iceberg-rest-server/Chart.yaml
+sed -i".tmp21" '24s/ tag: .*$/ tag: '"$NEXT_VERSION"'/g'
dev/charts/gravitino-iceberg-rest-server/values.yaml
+sed -i".tmp22" 's/^version: .*$/version: '"$NEXT_IRC_CHART_VERSION"'/g'
dev/charts/gravitino-iceberg-rest-server/Chart.yaml
+
+LRC_CHART_REV=$((LRC_CHART_REV + 1))
+NEXT_LRC_CHART_VERSION="${LRC_CHART_SHORT_VERSION}.${LRC_CHART_REV}"
+sed -i".tmp23" 's/appVersion: .*$/appVersion: '"$NEXT_VERSION"'/g'
dev/charts/gravitino-lance-rest-server/Chart.yaml
+sed -i".tmp24" '30s/ tag: .*$/ tag: '"$NEXT_VERSION"'/g'
dev/charts/gravitino-lance-rest-server/values.yaml
+sed -i".tmp25" 's/^version: .*$/version: '"$NEXT_LRC_CHART_VERSION"'/g'
dev/charts/gravitino-lance-rest-server/Chart.yaml
Review Comment:
Please add an empty line here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
